It is currently Thu Oct 29, 2020 10:18 pm

All times are UTC - 8 hours [ DST ]




Post new topic Reply to topic  [ 15 posts ] 
Author Message
Offline
 Post subject: Go4go recent delivery import error Kombilo
Post #1 Posted: Wed Jan 15, 2020 9:41 am 
Gosei

Posts: 1634
Location: Earth
Liked others: 609
Was liked: 279
When I try to add the recent go4go delivery of sgf files as database to kombilo, kombilo crashes.

Any pointers?

Top
 Profile  
 
Offline
 Post subject: Re: Go4go recent delivery import error Kombilo
Post #2 Posted: Wed Jan 15, 2020 9:45 am 
Gosei

Posts: 1634
Location: Earth
Liked others: 609
Was liked: 279
It is related to the sgf files. If I copy one of them to a working folder, this folder also breaks kombilo.

Reformating with sabaki does not solve the problem.

I am lost for now.

Top
 Profile  
 
Offline
 Post subject: Re: Go4go recent delivery import error Kombilo
Post #3 Posted: Wed Jan 15, 2020 9:50 am 
Gosei

Posts: 1634
Location: Earth
Liked others: 609
Was liked: 279
The sgf files load manually as single files without problem into kombilo.

Top
 Profile  
 
Offline
 Post subject: Re: Go4go recent delivery import error Kombilo
Post #4 Posted: Wed Jan 15, 2020 9:57 am 
Gosei

Posts: 1634
Location: Earth
Liked others: 609
Was liked: 279
Oh nooooo!

It is a year 2020 problem.

Changing the game year in the date field to a pre 2020 year solves the problem for this sgf file.

I have little hope there will be a new kombilo version without the error. On the other hand the source code is available ...

Top
 Profile  
 
Offline
 Post subject: Re: Go4go recent delivery import error Kombilo
Post #5 Posted: Wed Jan 15, 2020 10:36 am 
Lives in sente

Posts: 917
Location: UK
Liked others: 70
Was liked: 472
Rank: 5 dan
KGS: macelee
Can you explain this in more detail? I test my sgf package with Kombilo every week I have not experienced problem. Which version of Kombilo are you using?


This post by macelee was liked by: Gomoto
Top
 Profile  
 
Offline
 Post subject: Re: Go4go recent delivery import error Kombilo
Post #6 Posted: Wed Jan 15, 2020 10:56 am 
Gosei

Posts: 1634
Location: Earth
Liked others: 609
Was liked: 279
I am running Kombilo 0.8.4 on windows 10.

sgf without crash when [add DB] in kombilo is invoked (2020 changed to 2018 for testing purpose):



when I try to [add DB] a folder with this version of the file (only difference 2018 -> 2020) kombilo exits during [add DB] without error message.



Database -> Edit DB list -> Add DB (no crash with 2018, crash with 2020)

Top
 Profile  
 
Offline
 Post subject: Re: Go4go recent delivery import error Kombilo
Post #7 Posted: Wed Jan 15, 2020 1:14 pm 
Dies with sente

Posts: 72
Liked others: 8
Was liked: 22
Gomoto wrote:
Oh nooooo!

It is a year 2020 problem.

Changing the game year in the date field to a pre 2020 year solves the problem for this sgf file.

I have little hope there will be a new kombilo version without the error. On the other hand the source code is available ...


Have you tried changing the line

libkombilo/pattern.h:const int DATE_PROFILE_END = 2020;

?


This post by vier was liked by 3 people: Gomoto, macelee, xela
Top
 Profile  
 
Offline
 Post subject: Re: Go4go recent delivery import error Kombilo
Post #8 Posted: Wed Jan 15, 2020 2:38 pm 
Gosei

Posts: 1634
Location: Earth
Liked others: 609
Was liked: 279
I am sure this is the solution. But I am not able to compile from source in windows 10 (I do not know how to install sqlite3 in such a way sqlite.h is found during the build process of kombilo.) I will have to wait for an updated version of the windows installer.

Top
 Profile  
 
Offline
 Post subject: Re: Go4go recent delivery import error Kombilo
Post #9 Posted: Wed Jan 15, 2020 2:44 pm 
Lives in gote

Posts: 430
Location: Adelaide, South Australia
Liked others: 173
Was liked: 224
Rank: Australian 2 dan
GD Posts: 200
vier wrote:
libkombilo/pattern.h:const int DATE_PROFILE_END = 2020;

Why on earth would a developer put such a line in the code in the first place? Did he think we'd give up on playing go by the end of 2019? (Did the AlphaGo team somehow sneak that line into the Kombilo source? Let the conspiracy theories begin...)

Top
 Profile  
 
Offline
 Post subject: Re: Go4go recent delivery import error Kombilo
Post #10 Posted: Tue Jan 21, 2020 12:34 am 
Lives in gote

Posts: 430
Location: Adelaide, South Australia
Liked others: 173
Was liked: 224
Rank: Australian 2 dan
GD Posts: 200
Interesting, I'm not able to reproduce this issue (using the Linux version of Kombilo 0.8.4). I can add files with dates in 2020, or even 20201, with no problem.

Top
 Profile  
 
Offline
 Post subject: Re: Go4go recent delivery import error Kombilo
Post #11 Posted: Tue Jan 21, 2020 7:09 am 
Lives in gote

Posts: 573
Liked others: 20
Was liked: 32
Rank: Fox Tygem 6d
KGS: emerus
Tygem: emerus
OGS: emerus
I emailed the dev about the 2020 problem umm... three weeks ago or so. :) I hope he is aware of it, otherwise it would be nice if someone could compile it for Windows. :bow:

Top
 Profile  
 
Offline
 Post subject: Re: Go4go recent delivery import error Kombilo
Post #12 Posted: Sat Feb 15, 2020 12:08 pm 
Gosei

Posts: 1634
Location: Earth
Liked others: 609
Was liked: 279
Because I am too dumb to compile Kombilo in Windows :roll: I use this for now :lol:

Code:
package main

import (
        "io/ioutil"
        "log"
        "os"
        "strings"
)

func main() {
        a := os.Args[1:][0]
        d := "Downloads/" + a + "/"
        files, err := ioutil.ReadDir("Downloads/" + a)
        if err != nil {
                log.Fatal(err)
        }
        for _, fi := range files {
                f, _ := ioutil.ReadFile(d + fi.Name())
                s := string(f)
                s = strings.Replace(s, "DT[2020", "DT[1020", -1)
                err = ioutil.WriteFile(d+fi.Name(), []byte(s), 0644)
                if err != nil {
                        log.Fatal(err)
                }
        }
}

Top
 Profile  
 
Offline
 Post subject: Re: Go4go recent delivery import error Kombilo
Post #13 Posted: Wed Sep 23, 2020 11:22 am 
Dies in gote
User avatar

Posts: 63
Liked others: 0
Was liked: 40
Sorry for replying rather late.

I have received a few emails regarding this problem, and this issue was raised also on github. Even though the issue might be caused by the line mentioned above, I do not really understand that (and also, as was mentioned, it seems to be a Windows specific problem, which makes the thing even more mysterious).

As you may have guessed, I do not really have time to look deeper into this. (And even to change the one line and try whether that helps I would have to set up a (virtual) Windows machine etc., so it is not something I can do in 5 minutes.)

In fact, the whole Kombilo source code is quite outdated by now - the Python code should be moved over to Python 3, the C++ code should be updated as well. (And beyond that, it is also in principle appealing to move away from the current framework for the graphical user interface (Tkinter) to something more "modern".)

While in theory that is something I might like to do, it will definitively not happen within the next few months ... That does not necessarily mean that it would take that much time; but for me there are currently too many other things with a higher priority going on.

If anybody wants to have a go and fork (or take over) the Kombilo source code, or just reuse some of the things that are still useful, I will of course be happy to see that.

Sorry that I cannot be more helpful at this point.

Best regards, Ulrich

_________________
u-go.net

Top
 Profile  
 
Offline
 Post subject: Re: Go4go recent delivery import error Kombilo
Post #14 Posted: Wed Sep 23, 2020 11:35 am 
Gosei

Posts: 1634
Location: Earth
Liked others: 609
Was liked: 279
Thanks for Kombilo (I loved to use it and still use its library via Drago) and for your reply.

It somewhat helps to restore my selfconfidence to hear that it is no quick task to compile kombilo for windows even for its developer ;-)

Top
 Profile  
 
Offline
 Post subject: Re: Go4go recent delivery import error Kombilo
Post #15 Posted: Wed Sep 23, 2020 1:04 pm 
Lives with ko

Posts: 222
Liked others: 36
Was liked: 92
Rank: 2d
In case someone here doesn't read the other thread - I have implemented pattern search in q5go, and am looking for testers to make sure it works before making a new full release:

https://lifein19x19.com/viewtopic.php?p=260020#p260020

Other feedback and suggestions are also welcome. Adding some of the statistics features of Kombilo is still on the to-do list.

Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 15 posts ] 

All times are UTC - 8 hours [ DST ]


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group