It is currently Thu Mar 28, 2024 2:45 am

All times are UTC - 8 hours [ DST ]




Post new topic Reply to topic  [ 33 posts ]  Go to page Previous  1, 2
Author Message
Offline
 Post subject: Re: GoKibitz Alpha
Post #21 Posted: Mon Jan 05, 2015 9:41 am 
Oza

Posts: 2264
Liked others: 1180
Was liked: 552
cloudbrows wrote:
but Pandanet's "CoPyright" property does go flatly against the spec: http://www.red-bean.com/sgf/sgf4.html#2.2

actually it doesn't... there are only two uppercase letters in the keyword "CoPyright". But, you are correct that these are old style SGF properties. But IGS has been around for a very long time and that code probably hasn't been touched for years.

for example, PlayerWhite (PW) or GameName (GN) are perfectly valid property identifiers -- using only the two capital letters.

edit: found it. yes, they are old style
http://www.red-bean.com/sgf/converting.html
redbean wrote:
Property identifiers
In FF[1]-FF[3] lowercase letters where allowed in property identifiers, but in FF[4] only uppercase letters are allowed. I.e. the application has to remove all lowercase letters from the file.

Example: Black[qd];thisisaWhitemove[kk]bbrWyryrerwLerreoi[10.3] --> B[qd];W[kk]WL[10.3]


so if IGS/Pandanet is still using the old style property names but calling it FF[4], then yes, they are wrong.


This post by xed_over was liked by 2 people: cloudbrows, oca
Top
 Profile  
 
Offline
 Post subject: Re: GoKibitz Alpha
Post #22 Posted: Mon Jan 05, 2015 12:50 pm 
Dies in gote
User avatar

Posts: 34
Location: Washington, DC
Liked others: 12
Was liked: 29
Rank: AGA 2 kyu
KGS: cloudbrows
oca wrote:
Thanks, I tried to dowload the project on github and to make it work on my computer and I'm not that far...
the only thing that I cannot get to work is styling... all css seems to be missing... but that's not really a surprise as I have an error when using gulp... any idea what could be wrong ?
Code:
C:\Users\oca\Desktop\my\gokibitz-master-oca>gulp
[16:57:16] Using gulpfile ~\Desktop\my\gokibitz-master-oca\gulpfile.js
[16:57:16] Starting 'lint-server-js'...
[16:57:16] Starting 'sass-includes'...
[16:57:16] Finished 'sass-includes' after 2.57 ms
[16:57:16] Starting 'sass'...
[16:57:16] Starting 'browserify'...
[16:57:16] Bundling app.js...
[16:57:16] Starting 'fonts'...
[16:57:16] Starting 'js-assets'...
[16:57:16] Starting 'images'...
[16:57:16] Starting 'bootstrap-assets'...
[16:57:17] [gulp-sass] C:\Users\oca\Desktop\my\gokibitz-master-oca\client\src\sc
ss/lib/gokibitz:1: invalid top-level expression

[16:57:17] Finished 'sass' after 298 ms
[16:57:17] Finished 'js-assets' after 267 ms
[16:57:17] Finished 'bootstrap-assets' after 942 ms
[16:57:18] Finished 'lint-server-js' after 1.76 s
[16:57:29] Bundled app.js in 12 s
[16:57:29] Finished 'browserify' after 12 s
[16:57:29] Finished 'fonts' after 12 s
[16:57:29] gulp-imagemin: Minified 0 images
[16:57:29] Finished 'images' after 12 s
[16:57:29] Starting 'default'...
[16:57:29] Finished 'default' after 28 µs


That's awesome that you downloaded it and tried to get it running: I apologize for some messiness. I've been in "get this up and running!" mode and haven't spent any time on making it more hospitable for other devs.

Hmm... the only thing wrong is that the gulp-sass task is failing. Could you try pulling my most recent changes and running "gulp sass" on its own?

I haven't tried running this on a Windows computer, I don't know if that could possibly cause any issues. Feel free to hit me up on AIM (nateeagle5) if you'd like some help troubleshooting.

_________________
Nate Eagle

"You see, this is why go is so difficult. But also why go is so interesting." --Yuan Zhou

Top
 Profile  
 
Offline
 Post subject: Re: GoKibitz Alpha
Post #23 Posted: Tue Jan 06, 2015 12:29 am 
Lives in gote
User avatar

Posts: 699
Location: Switzerland
Liked others: 485
Was liked: 166
Rank: DDK
KGS: aco
IGS: oca
OGS: oca
cloudbrows wrote:
I apologize for some messiness. I've been in "get this up and running!" mode and haven't spent any time on making it more hospitable for other devs.

No problem, the code I saw so far looks really good to me...

cloudbrows wrote:
Hmm... the only thing wrong is that the gulp-sass task is failing. Could you try pulling my most recent changes and running "gulp sass" on its own?


First I must confess that I don't know anything about sass... but...

The problem seems to come from the file "client\src\scss\lib\_gokibitz.scss"
which contains a single line
Code:
../../submodules/wgo.js/themes/gokibitz/src/scss/gokibitz.scss

but the folder "../../submodules/wgo.js" is empty...

I just tried to comment that line and that seems to work... the application is running and I didn't noticed any problem so far... I will now try to get a bit more familiar with the code... and see if I can somehow mix my "gobook project" with your code, as I think that would be funny to post comment in the gobook format to display some variations directly on the comment (in the same way you allready use markdown)

_________________
Converting the book Shape UP! by Charles Matthews/Seong-June Kim
to the gobook format. last updated april 2015 - Index of shapes, p.211 / 216

Top
 Profile  
 
Offline
 Post subject: Re: GoKibitz Alpha
Post #24 Posted: Tue Jan 06, 2015 12:59 pm 
Dies in gote
User avatar

Posts: 34
Location: Washington, DC
Liked others: 12
Was liked: 29
Rank: AGA 2 kyu
KGS: cloudbrows
Ah, it's a submodule issue. I'm such an idiot. Just run
Code:
git submodule update --init --recursive
from the project root and you should be able to restore that line in _gokibitz.scss.

oca wrote:
I will now try to get a bit more familiar with the code... and see if I can somehow mix my "gobook project" with your code, as I think that would be funny to post comment in the gobook format to display some variations directly on the comment (in the same way you allready use markdown)


I'd love to see what you come up with - I love your idea of using gobook format.

_________________
Nate Eagle

"You see, this is why go is so difficult. But also why go is so interesting." --Yuan Zhou

Top
 Profile  
 
Offline
 Post subject: Re: GoKibitz Alpha
Post #25 Posted: Wed Jan 07, 2015 1:43 am 
Beginner

Posts: 15
Liked others: 0
Was liked: 3
oca wrote:
The sgf contains a 'CoPyright' property that WGo cannot parse. So the problem is not in your code. I suppose it's not even in WGo's code as property in SGF must be 2 uppercase letters (http://www.red-bean.com/sgf/sgf4.html) so the correct value must be just 'CP' in this case...

One should not assume that SGF is necessarily FF[4]. That latter standard is too strict and cannot be followed. There are many SGF files with the MULTIGOGM property. Also properties like KGSSB and KGSSW occur.

Top
 Profile  
 
Offline
 Post subject: Re: GoKibitz Alpha
Post #26 Posted: Wed Jan 07, 2015 4:15 am 
Lives in gote
User avatar

Posts: 699
Location: Switzerland
Liked others: 485
Was liked: 166
Rank: DDK
KGS: aco
IGS: oca
OGS: oca
zorq wrote:
oca wrote:
The sgf contains a 'CoPyright' property that WGo cannot parse. So the problem is not in your code. I suppose it's not even in WGo's code as property in SGF must be 2 uppercase letters (http://www.red-bean.com/sgf/sgf4.html) so the correct value must be just 'CP' in this case...

One should not assume that SGF is necessarily FF[4]. That latter standard is too strict and cannot be followed. There are many SGF files with the MULTIGOGM property. Also properties like KGSSB and KGSSW occur.


I agree, in the spec, that sentence really make sense to me :

http://www.red-bean.com/sgf/sgf4.html wrote:
Therefore, if one is writing a SGF reader, it is important to skip unknown properties. An application should issue a warning message when skipping unknown or faulty properties.

_________________
Converting the book Shape UP! by Charles Matthews/Seong-June Kim
to the gobook format. last updated april 2015 - Index of shapes, p.211 / 216

Top
 Profile  
 
Offline
 Post subject: Re: GoKibitz Alpha
Post #27 Posted: Wed Jan 07, 2015 8:33 am 
Dies in gote
User avatar

Posts: 34
Location: Washington, DC
Liked others: 12
Was liked: 29
Rank: AGA 2 kyu
KGS: cloudbrows
Sounds like I should try to fix it in WGo.js, then. WGo's creator was very nice the last time I submitted a pull request. I'll just add it to my list of things to do... :roll:

_________________
Nate Eagle

"You see, this is why go is so difficult. But also why go is so interesting." --Yuan Zhou

Top
 Profile  
 
Offline
 Post subject: Re: GoKibitz Alpha
Post #28 Posted: Thu Jan 08, 2015 8:48 am 
Lives in gote
User avatar

Posts: 699
Location: Switzerland
Liked others: 485
Was liked: 166
Rank: DDK
KGS: aco
IGS: oca
OGS: oca
cloudbrows wrote:

I'd love to see what you come up with - I love your idea of using gobook format.


Just a quick picture of a quick, very dirty try to add gobook style comment...
Attachment:
2015-01-08_133210.jpg
2015-01-08_133210.jpg [ 44.18 KiB | Viewed 6152 times ]

_________________
Converting the book Shape UP! by Charles Matthews/Seong-June Kim
to the gobook format. last updated april 2015 - Index of shapes, p.211 / 216

Top
 Profile  
 
Offline
 Post subject: Re: GoKibitz Alpha
Post #29 Posted: Thu Jan 08, 2015 11:41 am 
Dies in gote
User avatar

Posts: 34
Location: Washington, DC
Liked others: 12
Was liked: 29
Rank: AGA 2 kyu
KGS: cloudbrows
I'm really intrigued! This is kind of a different direction than I had been thinking for showing variations, but it's really interesting. The key for me, I think, would be finding a way to make it easy for commenters to generate that notation by interacting with the board.

(Thanks for caring enough about this to try something, btw! I appreciate it.)

_________________
Nate Eagle

"You see, this is why go is so difficult. But also why go is so interesting." --Yuan Zhou

Top
 Profile  
 
Offline
 Post subject: Re: GoKibitz Alpha
Post #30 Posted: Thu Jan 08, 2015 1:01 pm 
Lives in gote
User avatar

Posts: 699
Location: Switzerland
Liked others: 485
Was liked: 166
Rank: DDK
KGS: aco
IGS: oca
OGS: oca
sure, to be usable, there should be a way to edit the variation by clicking on a goban, not by typing text...

There are also a few technical issue, as my engine is not "angular ready" and did the DOM manipulation by itself... so there would be some rework to make something that integrate with your app in a cleaner way.

Just to give you an idea, for now the commentBox directive is modified like that which somehow work, but that's not really clean...

Code:
...
...
element.bind('keyup', function (event) {
   var key = event.keyCode || event.which;
   if (key === 27) {
      $scope.cancel();
   } else {
      
      if (element.val() !== text) {
         text = element.val();

         // [OCA]
         var content = text
         if (content.indexOf("::book") === 0) {
            
               var res = new GoBookParser().parse(content);
               var book = res.book;
               var engine = new GoBookEngine();
               var bridge = new GoBookBridge_WGO( $(".preview"), null);
               $(".preview").html("")
               engine.executeFromTo( book, bridge, "en", 0, 1);
            
         }
         //[/OCA]

         // Get an HTML preview of the markdown
         $http.post('/api/markdown/', {markdown: element.val()})
            .success(function (data) {
               $scope.preview = data.markup;
            });
      }
   }
});
...

...

_________________
Converting the book Shape UP! by Charles Matthews/Seong-June Kim
to the gobook format. last updated april 2015 - Index of shapes, p.211 / 216

Top
 Profile  
 
Offline
 Post subject: Re: GoKibitz Alpha
Post #31 Posted: Fri Jan 09, 2015 8:06 am 
Dies in gote
User avatar

Posts: 34
Location: Washington, DC
Liked others: 12
Was liked: 29
Rank: AGA 2 kyu
KGS: cloudbrows
I don't think it'll be too hard to rework it a little bit to integrate more cleanly. Ah ha: I just found the link to your GoBook resources: http://www.gocdf.ch/gobook/app/login.php

This looks cool! I'm sorry I hadn't heard of it till now. I think the "hows" aren't 100% ironed out in my head, but I really dig this approach, and I like the gobook format itself (props to Anders). I'll work on this soon!

_________________
Nate Eagle

"You see, this is why go is so difficult. But also why go is so interesting." --Yuan Zhou


This post by cloudbrows was liked by: Bonobo
Top
 Profile  
 
Offline
 Post subject: Re: GoKibitz Alpha
Post #32 Posted: Fri Jan 09, 2015 9:46 am 
Lives in gote
User avatar

Posts: 699
Location: Switzerland
Liked others: 485
Was liked: 166
Rank: DDK
KGS: aco
IGS: oca
OGS: oca
cloudbrows wrote:
I don't think it'll be too hard to rework it a little bit to integrate more cleanly. Ah ha: I just found the link to your GoBook resources: http://www.gocdf.ch/gobook/app/login.php

This looks cool! I'm sorry I hadn't heard of it till now. I think the "hows" aren't 100% ironed out in my head, but I really dig this approach, and I like the gobook format itself (props to Anders). I'll work on this soon!


Thanks ! you may also check that topic : viewtopic.php?p=176249#p176249

_________________
Converting the book Shape UP! by Charles Matthews/Seong-June Kim
to the gobook format. last updated april 2015 - Index of shapes, p.211 / 216


This post by oca was liked by: Bonobo
Top
 Profile  
 
Offline
 Post subject: Re: GoKibitz Alpha
Post #33 Posted: Mon Jul 11, 2016 2:02 am 
Dies with sente
User avatar

Posts: 74
Location: Germany
Liked others: 141
Was liked: 19
Rank: kgs 5 kyu
Universal go server handle: eyecatcher
Hi, i just want to share my experience with GOKibitz so far:

it is awesome! And not at all feeling buggy or whatever, it is very good useable, well designed and one of my favorite places for GO in the web.

So, i just wonder why not many many more people use it?! :scratch:


Maybe just give it a try :D

https://gokibitz.com

_________________
“Play where you want and don’t be afraid. If you’re chasing the dream you must take the risk.” Yasumasa Hane 9p

Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 33 posts ]  Go to page Previous  1, 2

All times are UTC - 8 hours [ DST ]


Who is online

Users browsing this forum: Google [Bot] and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group