Life In 19x19 http://lifein19x19.com/ |
|
Announcing GoReviewPartner - v0.15 with Pachi and PhoenixGo http://lifein19x19.com/viewtopic.php?f=9&t=14050 |
Page 10 of 16 |
Author: | pnprog [ Sun Mar 04, 2018 6:40 am ] |
Post subject: | Re: Announcing GoReviewPartner - v0.10 (supporting Leela Zer |
johnsmith wrote: Right after it played the last move, I immediately opened "start review" but there were only 7 moves analyzed. So I closed it, let the anlysis finish and then opened it again. And just then there were all the moves. So I was confused... it first calc-ed answers to my moves (up to move 12), then went back to move number 7 and calc-ed 7,8,9,10,11,12? Does it lose previous calcs that way? Cuz it may had an idea when played certain move, but had to find it again? Or it just cal-ed 7,9,11 beacuse 8,10,12 were stored somewhere? What happened is that you had 2 instances of Leela running at the same time on your computer (so they where not at the same game move). One that was performing the analysis, and one that was playing as white (with the second in advance because it does not have to analyse black moves). In this case, yes they won't necessary agree on the best move. If you want to have only one instance, you needs to select the bot that is labelled "Bot used for the analysis (XXXXX)": Attachment: live_img0.png [ 35.98 KiB | Viewed 17691 times ] The drawback in this case is that you have to wait for the bot to finish the analysis of its move AND your move before it continues playing So it's fine only if you take much more time thinking about your move than it does. (<- which is the case for me ) Note that if more than one bot has to be used, then you will see the option to make sure they don't think at the same time appears (see, the check box "No overlap thinking time" is not on the first image above): Attachment: live_img1.png [ 25.72 KiB | Viewed 17691 times ] At the beginning, I had considered something like you say: play move 12, then go back to move 3 for the analysis, then move again to move 14 if the opponent played move 13. But yes, it's a big big headache. In fact, I already had a very very hard time implementing the "Undo" feature considering the analyser and the players "work" on the same SGF tree (players extend the first branch, analyser adds other branches at each node, so one need to be careful when removing nodes of the first branch). The way I am using it now is having the slow instance performing the analysis, and the fast instance playing white or black. I don't use the thinking time limit any more, only the playouts limit from the command line. Plus, on Linux (but should be doable on windows) I set the analyser instance as a low priority process, so it won't slow down the fast instance. But because I use a playout limit without time limit, the quality of the analysis is still the same. Quote: Edit: I should probably just use human vs human in live analysis (just like last night) and everything is just perfect Yes, Human VS Human is what I imagine as "spectator mode" or "kibitz mode" There are still plenty of work in progress before the next release, I have plenty of things to polish, and I will have to spend time on the documentation as well. |
Author: | johnsmith [ Sun Mar 04, 2018 11:29 am ] |
Post subject: | Re: Announcing GoReviewPartner - v0.10 (supporting Leela Zer |
Oh, I see now, thanks for clarification! I will use "Bot used for the analysis (XXXXX)" when necessary. Quote: So it's fine only if you take much more time thinking about your move than it does. (<- which is the case for me ) Me too I also like using constant number of playouts/visits instead of time settings just because of these overlapings. Or maybe something else you're doing on your computer.
|
Author: | pnprog [ Wed Mar 07, 2018 8:16 am ] |
Post subject: | Re: Announcing GoReviewPartner - v0.10 (supporting Leela Zer |
snippy wrote: Hi again I spent quite a bit of time investigating this issue with the help of snippy.Might there still be a bug concerning handicap stones? I played a high handicap game against leela 0.11 and lost (White wins by -9 + 0.5 Komi + 14 Handicap). But after analyzing the game with GRP (with leela as bot) the win graph always stays around 100% win for black and for white leela even resigns close before endgame and keeps resigning every move just until the game ended. How can that be? As it appears, the issue was due to Leela value network unable to estimate games with too high number of handicap stones. In this specific case, the value network was giving black winner by a lot, and the Monte Carlo simulations were giving white winner by a lot. The winning rate (a function of both previous estimations) was around 50%, slightly above. This pushed me to implement graphs and "delta graphs" (<- this is the new name I gave to the "Comparison graph for black/white") for Value Network and Monte Carlo estimations. In case of doubt with the win rate, it is better to double check the two other "metrics": Attachment: all.png [ 99.76 KiB | Viewed 17638 times ] Ray, AQ and Leela have the three metrics available. Leela Zero has only the Value Network one (that is wrongly named Win Rate at the moment). (GnuGo has none of them ) As I was investigating this issue, I found an unexpected result with AQ and Ray. Both of them, in Chinese rule set, in handicap games:
Leela, LeelaZero and GnuGo all account for the number of handicap stones when calculating white score. I opened issues on both projects [1][2]. I mention that so that until it is fixed, be careful when playing handicap games against Ray and AQ. I also noticed some behaviour that may be a violation of the GTP protocol for Leela and Leela Zero: When they choose to resign, they create a move in their move history that requires to be undo if one want to go back in the game tree.
I think this is an area where the GTP protocol documentation is not clear enough. I did not opened an issue for this one, seems everybody has its work around. But clearly, this poses problem when using Leela/LeelaZero with Gogui. This was giving me headaches for the live analysis with Leela/LeelaZero. This is for such cases that I am happy I kept GnuGo around. It's implementation of the GTP protocol is somehow the reference implementation. So when it works with GnuGo but not for another bot, I can start to look into such details. |
Author: | pnprog [ Thu Mar 08, 2018 9:23 am ] |
Post subject: | Re: Announcing GoReviewPartner - v0.10 (supporting Leela Zer |
pnprog wrote: I also noticed some behaviour that may be a violation of the GTP protocol for Leela and Leela Zero: Apparently, this has been fixed for Leela Zero in v0.10, v.11 or v.12
When they choose to resign, they create a move in their move history that requires to be undo if one want to go back in the game tree.
I think this is an area where the GTP protocol documentation is not clear enough. I did not opened an issue for this one, seems everybody has its work around. But clearly, this poses problem when using Leela/LeelaZero with Gogui. |
Author: | pnprog [ Thu Mar 08, 2018 9:53 am ] |
Post subject: | Re: Announcing GoReviewPartner - v0.10 (supporting Leela Zer |
This is me again! A gentleman on Github has proposed a different layout for GRP, that integrate the graph inside the main view: Attachment: new_layout0.png [ 20.86 KiB | Viewed 17609 times ] He went as far as to make a modification of the code to get a better idea. It would looks more or less like that (consider this as a draft, it would need some more polishing): Attachment: new_layout.png [ 214.83 KiB | Viewed 17609 times ] I also believe GRP GUI would require a new layout. I would like to ask all of you for suggestion, comments, and so on. Maybe I should start a different thread for that, but I don't want to spam L19 with GRP threads For reference, the initial discussion is on github there. |
Author: | johnsmith [ Thu Mar 08, 2018 1:37 pm ] |
Post subject: | Re: Announcing GoReviewPartner - v0.10 (supporting Leela Zer |
I like this new layout idea. But only wonder how would graph fit in such a small area, would you be able to see red and green deltas? |
Author: | redreoicy [ Fri Mar 16, 2018 12:12 pm ] |
Post subject: | Re: Announcing GoReviewPartner - v0.10 (supporting Leela Zer |
Does anyone know how to use updated versions of leelazero with GoReviewPartner? (current weights and/or .exe) Edit: I think I've figured out the weights, but not how to use updated leela versions. |
Author: | pnprog [ Mon Mar 19, 2018 3:52 am ] |
Post subject: | Re: Announcing GoReviewPartner - v0.10 (supporting Leela Zer |
redreoicy wrote: Does anyone know how to use updated versions of leelazero with GoReviewPartner? (current weights and/or .exe) Edit: I think I've figured out the weights, but not how to use updated leela versions. It works the same way as for example, Sabaki:
Beware that latest version of Leela will forcefully run the tuner when starting the bot the first time. This will block GRP for a while. |
Author: | redreoicy [ Tue Mar 20, 2018 8:26 pm ] |
Post subject: | Re: Announcing GoReviewPartner - v0.10 (supporting Leela Zer |
Always I get an error saying ERROR: Leela Zero did not identified itself as expected 'Leela Zero' != '' and nothing happens But when I completely replaced the Leela Zero folder with a fresh download of the windows 64 (notcpuonly) it is working. I'm not sure if the type of leela I downloaded mattered (earlier I downloaded cpuonly as I wasn't sure if my computer had a gpu or if there was something else I did differently. Anyway it all seems well now. By the way, thanks for the help and amazing program! |
Author: | pnprog [ Thu Mar 22, 2018 8:51 am ] |
Post subject: | Re: Announcing GoReviewPartner - v0.10 (supporting Leela Zer |
redreoicy wrote: Always I get an error saying The error message above typically appears when Leela Zero fails to start in GTP mode. It could be that the program fails because it cannot find the weight file, or the --gtp parameter was not added.ERROR: Leela Zero did not identified itself as expected 'Leela Zero' != '' and nothing happens On the next version, I have added a handful of error detection for Leela Zero, related to weight file, this will hopefully avoid more headaches. |
Author: | Sneegurd [ Thu Mar 29, 2018 6:00 am ] |
Post subject: | Re: Announcing GoReviewPartner - v0.10 (supporting Leela Zer |
What is this? Installed Python, use absolute path for Leela. Weightsfile is "bestnet" here. Saving the settings in UI it says below. It's on Win7x64, thanks! Path: c:\Users\Michel\programme\Drago\Engines\LeelaZero\leelaz.exe Settings: gtp --noponder --weights bestnet Code: STDIN encoding: cp850 STDOUT encoding: cp850 STDERR encoding: cp850 File system encoding: mbcs GRP path: C:\Users\Michel\Programme\GRP Config file: C:\Users\Michel\Programme\GRP\config.ini Reading language setting from config file lang=de Loading translation file: C:\Users\Michel\Programme\GRP\translations\de.po Could not import the WX GUI library, please double check it is installed: No module named wx => Falling back to tkFileDialog Checking availability of config file refreshing Adding new popup Totally 1 popups Code: Saving LeelaZero settings
refreshing Exception in Tkinter callback Traceback (most recent call last): File "C:\Python27\lib\lib-tk\Tkinter.py", line 1541, in __call__ return self.func(*args) File "C:\Users\Michel\Programme\GRP\leela_analysis.py", line 465, in <lambda> Button(self, text=_("Test"),command=lambda: self.parent.parent.test(self.gtp ,"fast")).grid(row=row,column=1,sticky=W) File "C:\Users\Michel\Programme\GRP\settings.py", line 218, in test from gtp_terminal import Terminal ImportError: No module named gtp_terminal Initializing GRP setting interface Initializing LeelaZero setting interface |
Author: | pnprog [ Sat Mar 31, 2018 8:05 am ] |
Post subject: | Re: Announcing GoReviewPartner - v0.10 (supporting Leela Zer |
Hi! Sneegurd wrote: Code: STDIN encoding: cp850 STDOUT encoding: cp850 STDERR encoding: cp850 File system encoding: mbcs GRP path: C:\Users\Michel\Programme\GRP Config file: C:\Users\Michel\Programme\GRP\config.ini Reading language setting from config file lang=de Loading translation file: C:\Users\Michel\Programme\GRP\translations\de.po Could not import the WX GUI library, please double check it is installed: No module named wx => Falling back to tkFileDialog Checking availability of config file refreshing Adding new popup Totally 1 popups This is normal: originally, GRP used the tkinter (GUI tollkit) file pickers (the widgets used to select files to open or save). Then a contributor sent a patch to replace those tkinter widget by the file pickers of wxpython, another GUI toolkit, because the latter are more beautiful and easier to use. They are the same as the system, with your usual bookmark. So if you happen to have wxpython installed on your system (which is often the case for Linux) then it will be used. Otherwise, GRP uses the usual tkinter widget. In fact, for the future, I am considering moving entirely GRP to wxpython. Sneegurd wrote: Code: Saving LeelaZero settings refreshing Exception in Tkinter callback Traceback (most recent call last): File "C:\Python27\lib\lib-tk\Tkinter.py", line 1541, in __call__ return self.func(*args) File "C:\Users\Michel\Programme\GRP\leela_analysis.py", line 465, in <lambda> Button(self, text=_("Test"),command=lambda: self.parent.parent.test(self.gtp ,"fast")).grid(row=row,column=1,sticky=W) File "C:\Users\Michel\Programme\GRP\settings.py", line 218, in test from gtp_terminal import Terminal ImportError: No module named gtp_terminal Initializing GRP setting interface Initializing LeelaZero setting interface I just published the version 0.11 of GRP, you can download it for windows from here: http://ns1297.imingo.net/ (make sure to refresh the page, F5, in case you visited it recently). I haven't finished updating the documentation, so no announcement yet. |
Author: | Caesura [ Sun Apr 01, 2018 9:56 am ] |
Post subject: | Re: Announcing GoReviewPartner - v0.10 (supporting Leela Zer |
Hi, is it possible to provide an option to download GRP with CPU-only Leelazero? Thank you! |
Author: | snippy [ Thu Apr 05, 2018 9:46 am ] |
Post subject: | Re: Announcing GoReviewPartner - v0.10 (supporting Leela Zer |
Hi there, would it be possible to change the table behavior in such a way, that it auto-updates when you step through the game moves? For me it will stay on the move that it has been opened with! Take care and thanks a lot! |
Author: | Sneegurd [ Sat Apr 07, 2018 10:49 pm ] |
Post subject: | Re: Announcing GoReviewPartner - v0.10 (supporting Leela Zer |
Hi, I'm using the Leela Zero version from http://ns1297.imingo.net/ The below text boxes do not scale when the window is stretched vertically. Text boxes end with "Black Value Network win probability:" - for the interesting part I have to scroll. Instead, GRP shows plenty of unused space. Can this be changed? I used "Convert RSGF" on a rsgf file it just created, this is what happens: Code: Convertion of C:/Users/Snee/Desktop/11468837-103-Haylee-maufred.rsgf into C:/U
sers/Snee/Desktop/11468837-103-Haylee-maufred.rsgf.sgf Exception in Tkinter callback Traceback (most recent call last): File "Tkinter.pyc", line 1532, in __call__ File "main.py", line 74, in r2sgf File "r2sgf.pyc", line 16, in rsgf2sgf File "gomill\sgf.pyc", line 194, in set File "gomill\sgf_properties.pyc", line 730, in serialise File "gomill\sgf_properties.pyc", line 695, in serialise_as_type File "gomill\sgf_properties.pyc", line 264, in serialise_text UnicodeEncodeError: 'latin-1' codec can't encode character u'\u2022' in position 261: ordinal not in range(256) |
Author: | luchador [ Sun Apr 08, 2018 4:52 pm ] |
Post subject: | Re: Announcing GoReviewPartner - v0.10 (supporting Leela Zer |
Hello: I just want to say THANK YOU to our friend pnprog, for all the work done. Excellent! |
Author: | pnprog [ Mon Apr 09, 2018 1:02 am ] |
Post subject: | Re: Announcing GoReviewPartner - v0.10 (supporting Leela Zer |
Hi! I was out of town last week, so no time to work on GRP. Caesura wrote: Hi, is it possible to provide an option to download GRP with CPU-only Leelazero? Thank you! Yep no problem. I think the 64bit version is fine? Sneegurd wrote: The below text boxes do not scale when the window is stretched vertically. Text boxes end with "Black Value Network win probability:" - for the interesting part I have to scroll. Instead, GRP shows plenty of unused space. Can this be changed? I will see what can be done. Those two text boxes are really not satisfying Sneegurd wrote: I used "Convert RSGF" on a rsgf file it just created, this is what happens: The exact same problem was reported on Github, I will investigate this.snippy wrote: would it be possible to change the table behavior in such a way, that it auto-updates when you step through the game moves? For me it will stay on the move that it has been opened with! Yes, I will change that.luchador wrote: I just want to say THANK YOU to our friend pnprog, for all the work done. Excellent! Thanks you! Encouragements are much appreciated
|
Author: | Caesura [ Mon Apr 09, 2018 7:37 am ] |
Post subject: | Re: Announcing GoReviewPartner - v0.10 (supporting Leela Zer |
pnprog wrote: Hi! Caesura wrote: Hi, is it possible to provide an option to download GRP with CPU-only Leelazero? Thank you! Yep no problem. I think the 64bit version is fine? Thank you! 64 bit is fine |
Author: | pnprog [ Mon Apr 09, 2018 8:15 am ] |
Post subject: | Re: Announcing GoReviewPartner - v0.11 with live analysis |
Hi everybody! So I finally found the time to complete the documentation of v0.11, so here is the official announcement The big change for that version are:
For the live analysis, I am going to copy paste the description I put in the documentation: A live analysis makes it possible to record a game or play against a bot, while, in the background, having the analysis proceed. This is a way to save on the analysis time, so that when the game is over, part of the analysis is already completed, and the review can start immediately. It also has the advantage to make the result of the analysis directly available (given the bot performing the analysis is fast enough to catch up with the game speed) which is interesting during a live review. So first, you have to select the bot that will perform the analysis. It is probably better to select a slow profile bot. Second, you select who will be playing as black and white. You basically have three options:
So here are different way to use the live analysis mode:
When a bot is selected as black or white, that is not the same as the bot used for analysis, or when black and white are played by different bots, then an additional option appears No overlap thinking time that indicates to GRP to make sure the bots are no thinking at the same time, so that your computer processing power (CPU, GPU, RAM) does not becomes a shared resource. Depending of the situation, this option will be or won't be useful:
Generally speaking, it is best to use play-outs limits for your bots. You can also set the process of the bot performing the analysis to run at low priority, so that it won't make your opponent slower. During the live analysis, there is an Open position button available at any time to try out variations. And when the analysis for the 2 first moves is completed, a Start review button will appear that starts the usual review panel for this game. Of course, only the moves already analysed will be available, but the review panel will update itself automatically as the analysis progresses. So basically I have been using this mode a lot since i started implementing it, playing Live against an older version of Leela Zero, and having our game reviewed by Leela. To me this was eye opening. Some of the other improvements since v0.10:
pnprog wrote: Added plenty of new bugs In fact, I now realize I tried to put too much things into this version, and by doing so, I kept delaying and delaying and delaying this new v0.11, which is detrimental to GRP. More frequent small versions are better to try out the features and find bugs. In fact, there are more bugs than usual in this version, because it's hard for me now to try out all configurations options and combination of those options.So I will probably release a v0.11.1 soon after I fix all current issues, before going on implement more features. For the next version v0.12, the main feature I plan to add is support for generic GTP bots that can be used in Live Analysis (and Open Position). Now, we have plenty of very strong bots to analyse our games, and it's good also to have some weaker bots to play against (while leaving the analysis to the strong bots of course). Then Ideally, that v0.12 will be the last version before v1.0 For v1.0, v1.1, v1.2, v1.3... I would like to stop adding new features, only maintenance:
Then, once V1.0 will be out and living it's own life ("in production" as they say), I will probably slowly start a v2, that will be a restart from scratch, avoiding the design issues I made with v1, probably using wxpython instead of tkinter, python3 instead of python2, and that one will be opened to new features. So, here you are:
|
Author: | pnprog [ Mon Apr 09, 2018 10:25 pm ] |
Post subject: | Re: Announcing GoReviewPartner - v0.10 (supporting Leela Zer |
Caesura wrote: Hi, is it possible to provide an option to download GRP with CPU-only Leelazero? Thank you! I just added the link on the download page.
|
Page 10 of 16 | All times are UTC - 8 hours [ DST ] |
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group http://www.phpbb.com/ |