Page 2 of 2

Re: Scoring estimate question

Posted: Mon May 24, 2010 11:49 am
by Li Kao
Why does SE only work with the offline client? Does it contain unverifiable or native code?

Re: Scoring estimate question

Posted: Mon May 24, 2010 12:35 pm
by wms
Originally, the SE was almost as big as the rest of the client put together, so I left it out of the applet to help people with slow internet connections.

But now the client is bigger and very few people are still on dialup, so it makes no sense to leave it out. When I get around to it I should add it to the applet.

Re: Scoring estimate question

Posted: Tue May 25, 2010 8:53 am
by Marcus
wms wrote:Yeah, the score estimator was written by a Mr. Yoshikawa. He was a friend of Richard Bozulich's. I met him in Japan and he offered his board evaluation code to KGS, I built the estimator out of it from that.

I do not know how the algorithm works. Several people have looked at the code (I give it away when Mr. Yoshikawa gives me permission to). They all wanted to make small, simple changes (work with non-19x19 boards, let the player say that a group is alive or dead, etc.)...they all ran away screaming when they saw the code. It is very, uhhh, peculiarly, written. :o


This makes me VERY curious. Any chance you could get permission to pass along the code to me? I don't need it or anything, I just want to look at the code. Anything that resists refactoring like that MUST me interesting. :D

Re: Scoring estimate question

Posted: Tue May 25, 2010 9:25 am
by wms
Marcus wrote:This makes me VERY curious. Any chance you could get permission to pass along the code to me? I don't need it or anything, I just want to look at the code. Anything that resists refactoring like that MUST me interesting. :D
You'll have to find and ask Yoshikawa yourself.

But here's a hint as to the troubles with it:

* No comments
* Functions thousands of lines long
* All variables (and most functions and even many of the classes) have single-letter names
* Chars used as enums (e.g., code like "if (y < 5) { z = 'j'; }" is all over the place.)

So you've been warned. :twisted:

Re: Scoring estimate question

Posted: Tue May 25, 2010 9:55 am
by Harleqin
Heh, me too :).

Re: Scoring estimate question

Posted: Tue May 25, 2010 12:02 pm
by palapiku
wms wrote:
Marcus wrote:This makes me VERY curious. Any chance you could get permission to pass along the code to me? I don't need it or anything, I just want to look at the code. Anything that resists refactoring like that MUST me interesting. :D
You'll have to find and ask Yoshikawa yourself.

But here's a hint as to the troubles with it:

* No comments
* Functions thousands of lines long
* All variables (and most functions and even many of the classes) have single-letter names
* Chars used as enums (e.g., code like "if (y < 5) { z = 'j'; }" is all over the place.)

So you've been warned. :twisted:

This would have been impressive had the code actually worked well.

Re: Scoring estimate question

Posted: Tue May 25, 2010 1:12 pm
by Marcus
wms wrote:
Marcus wrote:This makes me VERY curious. Any chance you could get permission to pass along the code to me? I don't need it or anything, I just want to look at the code. Anything that resists refactoring like that MUST me interesting. :D
You'll have to find and ask Yoshikawa yourself.

But here's a hint as to the troubles with it:

* No comments
* Functions thousands of lines long
* All variables (and most functions and even many of the classes) have single-letter names
* Chars used as enums (e.g., code like "if (y < 5) { z = 'j'; }" is all over the place.)

So you've been warned. :twisted:


Ouch ... still that's not as bad as I've seen (really!).

Re: Scoring estimate question

Posted: Fri May 28, 2010 8:12 pm
by ketchup
The correct answer is that it accounts for black living via ko threat.