Page 1 of 2
Go4go recent delivery import error Kombilo
Posted: Wed Jan 15, 2020 9:41 am
by Gomoto
When I try to add the recent go4go delivery of sgf files as database to kombilo, kombilo crashes.
Any pointers?
Re: Go4go recent delivery import error Kombilo
Posted: Wed Jan 15, 2020 9:45 am
by Gomoto
It is related to the sgf files. If I copy one of them to a working folder, this folder also breaks kombilo.
Reformating with sabaki does not solve the problem.
I am lost for now.
Re: Go4go recent delivery import error Kombilo
Posted: Wed Jan 15, 2020 9:50 am
by Gomoto
The sgf files load manually as single files without problem into kombilo.
Re: Go4go recent delivery import error Kombilo
Posted: Wed Jan 15, 2020 9:57 am
by Gomoto
Oh nooooo!
It is a year 2020 problem.
Changing the game year in the date field to a pre 2020 year solves the problem for this sgf file.
I have little hope there will be a new kombilo version without the error. On the other hand the source code is available ...
Re: Go4go recent delivery import error Kombilo
Posted: Wed Jan 15, 2020 10:36 am
by macelee
Can you explain this in more detail? I test my sgf package with Kombilo every week I have not experienced problem. Which version of Kombilo are you using?
Re: Go4go recent delivery import error Kombilo
Posted: Wed Jan 15, 2020 10:56 am
by Gomoto
I am running Kombilo 0.8.4 on windows 10.
sgf without crash when [add DB] in kombilo is invoked (2020 changed to 2018 for testing purpose):
when I try to [add DB] a folder with this version of the file (only difference 2018 -> 2020) kombilo exits during [add DB] without error message.
Database -> Edit DB list -> Add DB (no crash with 2018, crash with 2020)
Re: Go4go recent delivery import error Kombilo
Posted: Wed Jan 15, 2020 1:14 pm
by vier
Gomoto wrote:Oh nooooo!
It is a year 2020 problem.
Changing the game year in the date field to a pre 2020 year solves the problem for this sgf file.
I have little hope there will be a new kombilo version without the error. On the other hand the source code is available ...
Have you tried changing the line
libkombilo/pattern.h:const int DATE_PROFILE_END = 2020;
?
Re: Go4go recent delivery import error Kombilo
Posted: Wed Jan 15, 2020 2:38 pm
by Gomoto
I am sure this is the solution. But I am not able to compile from source in windows 10 (I do not know how to install sqlite3 in such a way sqlite.h is found during the build process of kombilo.) I will have to wait for an updated version of the windows installer.
Re: Go4go recent delivery import error Kombilo
Posted: Wed Jan 15, 2020 2:44 pm
by xela
vier wrote:
libkombilo/pattern.h:const int DATE_PROFILE_END = 2020;
Why on earth would a developer put such a line in the code in the first place? Did he think we'd give up on playing go by the end of 2019? (Did the AlphaGo team somehow sneak that line into the Kombilo source? Let the conspiracy theories begin...)
Re: Go4go recent delivery import error Kombilo
Posted: Tue Jan 21, 2020 12:34 am
by xela
Interesting, I'm not able to reproduce this issue (using the Linux version of Kombilo 0.8.4). I can add files with dates in 2020, or even 20201, with no problem.
Re: Go4go recent delivery import error Kombilo
Posted: Tue Jan 21, 2020 7:09 am
by emerus
I emailed the dev about the 2020 problem umm... three weeks ago or so.
I hope he is aware of it, otherwise it would be nice if someone could compile it for Windows.
Re: Go4go recent delivery import error Kombilo
Posted: Sat Feb 15, 2020 12:08 pm
by Gomoto
Because I am too dumb to compile Kombilo in Windows
I use this for now
Code: Select all
package main
import (
"io/ioutil"
"log"
"os"
"strings"
)
func main() {
a := os.Args[1:][0]
d := "Downloads/" + a + "/"
files, err := ioutil.ReadDir("Downloads/" + a)
if err != nil {
log.Fatal(err)
}
for _, fi := range files {
f, _ := ioutil.ReadFile(d + fi.Name())
s := string(f)
s = strings.Replace(s, "DT[2020", "DT[1020", -1)
err = ioutil.WriteFile(d+fi.Name(), []byte(s), 0644)
if err != nil {
log.Fatal(err)
}
}
}
Re: Go4go recent delivery import error Kombilo
Posted: Wed Sep 23, 2020 11:22 am
by ugoertz
Sorry for replying rather late.
I have received a few emails regarding this problem, and this issue was raised also on github. Even though the issue might be caused by the line mentioned above, I do not really understand that (and also, as was mentioned, it seems to be a Windows specific problem, which makes the thing even more mysterious).
As you may have guessed, I do not really have time to look deeper into this. (And even to change the one line and try whether that helps I would have to set up a (virtual) Windows machine etc., so it is not something I can do in 5 minutes.)
In fact, the whole Kombilo source code is quite outdated by now - the Python code should be moved over to Python 3, the C++ code should be updated as well. (And beyond that, it is also in principle appealing to move away from the current framework for the graphical user interface (Tkinter) to something more "modern".)
While in theory that is something I might like to do, it will definitively not happen within the next few months ... That does not necessarily mean that it would take that much time; but for me there are currently too many other things with a higher priority going on.
If anybody wants to have a go and fork (or take over) the Kombilo source code, or just reuse some of the things that are still useful, I will of course be happy to see that.
Sorry that I cannot be more helpful at this point.
Best regards, Ulrich
Re: Go4go recent delivery import error Kombilo
Posted: Wed Sep 23, 2020 11:35 am
by Gomoto
Thanks for Kombilo (I loved to use it and still use its library via Drago) and for your reply.
It somewhat helps to restore my selfconfidence to hear that it is no quick task to compile kombilo for windows even for its developer
Re: Go4go recent delivery import error Kombilo
Posted: Wed Sep 23, 2020 1:04 pm
by bernds
In case someone here doesn't read the other thread - I have implemented pattern search in q5go, and am looking for testers to make sure it works before making a new full release:
viewtopic.php?p=260020#p260020
Other feedback and suggestions are also welcome. Adding some of the statistics features of Kombilo is still on the to-do list.