Announcing GoReviewPartner - v0.15 with Pachi and PhoenixGo

[johnsmith]

New Ray is out which is ladder-conscious. It uses elf network with human added ladder knowledge. Someone on reddit said that the new Ray is beating LZ 100% because of no ladder weakness.
https://github.com/zakki/Ray/releases

But for some reason, GRP doesn't work with this ray. Is it just me?

[Calvin Clark]

But for some reason, GRP doesn't work with this ray. Is it just me?

Are you running the RLO version? If so, it has a different GTP name, "RLO", instead of "Rayon." I made these changes to ray_analysis.py just as a workaround, although this is not a formal fix. (Just change Rayon to RLO everywhere.)

diff --git a/ray_analysis.py b/ray_analysis.py
index d4a3a46..aa3adbf 100644
--- a/ray_analysis.py
+++ b/ray_analysis.py
@@ -132,7 +132,7 @@ class RayAnalysis():
return ray

def ray_starting_procedure(sgf_g,profile="slow",silentfail=False):
- return bot_starting_procedure("Ray","Rayon",Ray_gtp,sgf_g,profile,silentfail)
+ return bot_starting_procedure("Ray","RLO",Ray_gtp,sgf_g,profile,silentfail)


class RunAnalysis(RayAnalysis,RunAnalysisBase):
@@ -305,7 +305,7 @@ class RayOpenMove(BotOpenMove):

Ray={}
Ray['name']="Ray"
-Ray['gtp_name']="Rayon"
+Ray['gtp_name']="RLO"
Ray['analysis']=RayAnalysis
Ray['openmove']=RayOpenMove
Ray['settings']=RaySettings

[johnsmith]

Just change Rayon to RLO everywhere.

Awesome, it works!

[johnsmith]

Baduk1 channel from youtube made a nice analysis of the most recent Lee Sedol game using Elf engine with a lot of playouts: https://www.youtube.com/watch?v=8yZjtJu2lM0
And here's the sgf: http://eidogo.com/#1fo7mSKKW
I wanted to analyze this game myself, but baduk1 did it first

Besides a beautiful game, one thing to notice is that baduk1 channel used GRP v10. I don't know why he used v10, but I also prefer v10 because the winrate is shown for every move in this format B%/W%. And no need to scroll to see all comments for every move.

Edit: some more.
https://youtu.be/EvbM8kUEsRI
http://eidogo.com/#vnfyKPNS

https://www.youtube.com/watch?v=IseK4Bh1LDk
http://eidogo.com/#ymzstdin

[pnprog]

Thank you so much for all your work on this brilliant program.

I'd like to second dontbtme's last post: it would be really brilliant to do all the analysis, but then be able to choose the depth of review when you actually start the reviewing. Sometimes I want to see all the interesting sequences the AI would expect in my games but at other times I just want to concentrate on understanding my big mistakes. To have everything stored but then be able to filter it to a set number of variations or a certain mistake threshold would be really ideal.

I basically agree, I need some time to think over this, and come up with a good solution (something simple).

To volunteer a more tame idea - would it be possible to allow batch analysis of a few sgf files? I guess the file picker could just allow you to pick more than one file and then it would queue up the files for processing?

For the moment, this option is available when running GRP with python, it can be scripted in a BAT file (windows) or bash file (Linux/MacOs). I know running it from command line is not ideal

[pnprog]

New Ray is out which is ladder-conscious.

It's good to see this project active again!

Are you running the RLO version? If so, it has a different GTP name, "RLO", instead of "Rayon." I made these changes to ray_analysis.py just as a workaround, although this is not a formal fix. (Just change Rayon to RLO everywhere.)

Wow, that's cool! I have been busy those past two weeks, so I have many things to catch up. If it works for you, could you send a pull request on the github project? I will gladly accept it. I guess future version of Ray will all be name RLO anyway, and it's better to support the latest version anyway.

[bernds]

I also prefer v10 because the winrate is shown for every move in this format B%/W%. And no need to scroll to see all comments for every move.

Yeah, the text boxes could stand to be a little taller so you can read everything without scrolling. That's a change I made locally after unsuccessfully trying to get the Tk layout engine to resize them automatically.

[pnprog]

Baduk1 channel from youtube made a nice analysis of the most recent Lee Sedol game using Elf engine with a lot of playouts: https://www.youtube.com/watch?v=8yZjtJu2lM0
And here's the sgf: http://eidogo.com/#1fo7mSKKW
I wanted to analyze this game myself, but baduk1 did it first

Very nice video, thanks for the share! It's fun, I started noticing mentions of GRP in many places
One such mention of GRP was on this Taiwan blog: http://www.kenming.idv.tw/let-go-ai_as_the-go-review-partner/

Besides a beautiful game, one thing to notice is that baduk1 channel used GRP v10. I don't know why he used v10, but I also prefer v10 because the winrate is shown for every move in this format B%/W%. And no need to scroll to see all comments for every move.

Yes, I also miss that info. I will find a way to put it back in the UI.

Regarding the UI: I received a lot of help to improve the UI last months. It's still in development, but the current UI looks like this:

screenshot1.png (61.26 KiB) Viewed 18300 times

So there is only one comment box now, on the right side. By default, it shows the comments that were used in the left side box. And when a variation is displayed, the comment then show the variation data. Those comments are very verbose, and are intended for users that don't have much experience with bots, GRP and all that AI vocabulary.

screenshot2.png (61.94 KiB) Viewed 18300 times

Then, it's possible to replace those comments by the table. It's still work in progress, but the idea is that the table is for more experienced users, sort of "hardcore gamers". They are the same info, but will be condensed a lot, and not verbose at all. But all infos are available at a glance.

screenshot3.png (68.4 KiB) Viewed 18300 times

The size of both gobans and the comments/table panel can be adjusted horizontally (and GRP can be resized vertically) at your convenience, to the point that you can make the left goban (or the right one) totally invisible.

The current development version is very buggy, so maybe don't try it at the moment. I received support (and a new translation) from one Chinese user, and he help me find plenty of encoding issues when working with SGF files that have eastern encoding. I have still a lot of work to do to make it work properly.

[johnsmith]

Very nice video, thanks for the share! It's fun, I started noticing mentions of GRP in many places

Well, it's very well deserved and useful.

Those comments are very verbose, and are intended for users that don't have much experience with bots, GRP and all that AI vocabulary.

Totally agree on this. I prefer "hardcore gamer" layout myself as a 6d, because it's very neat and you can glance at all the necessary data quickly and efficiently. But then there would be lots of guys asking what everything means, which may turn away some people. So a switch button seems ideal, or text explanation underneath just like in Lizzie?

The size of both gobans and the comments/table panel can be adjusted horizontally (and GRP can be resized vertically) at your convenience, to the point that you can make the left goban (or the right one) totally invisible.

Nice idea, since that way you can satisfy both one-screeners and two-screeners. and B%/W% format can maybe be satisfied with one extra column to the table on the last screenshot? Just an idea...

Can I suggest a tiny-small-little change? I originally suggested a yellow bar somewhere in this thread, but as I'm a nightly owl, I usually have f.lux turned on all the time, and have problem seeing the yellow_bar. I myself can change it in dual_view.py (to something like this color #F39C12 for example), but maybe some people would like a darker color instead and don't know how to do it.

Great work as always, thx!

[dfan]

Can I suggest a tiny-small-little change? I originally suggested a yellow bar somewhere in this thread, but as I'm a nightly owl, I usually have f.lux turned on all the time, and have problem seeing the yellow_bar. I myself can change it in dual_view.py (to something like this color #F39C12 for example), but maybe some people would like a darker color instead and don't know how to do it.

Yes please! This affects me as well.

[sleepyEDB]

Really liking that new UI, can't wait!

Quick question and my apologies if it's been asked before: I'm noticing that GRP with Leela is using what I would consider a low number of playouts for each of the top recommended moves in a 19x19 game:

GRP_Playouts.png (7.94 KiB) Viewed 18209 times

I've seen that number go as high as 15K but most are around 5K. I could very well be mistaken, but aren't they supposed to be around 100K; or is that for all variations combined? The settings I used to run the SGF analysis are below for reference.

GRP_Analysis_Settings.png (10.68 KiB) Viewed 18209 times

Thanks,


sleepy

[MikeKyle]

To volunteer a more tame idea - would it be possible to allow batch analysis of a few sgf files? I guess the file picker could just allow you to pick more than one file and then it would queue up the files for processing?

For the moment, this option is available when running GRP with python, it can be scripted in a BAT file (windows) or bash file (Linux/MacOs). I know running it from command line is not ideal

I actually think this BAT file idea would allow me to do some really fun stuff. I'd be really interested to use GRP this way.

However, so far I'm getting errors when I try to run at the command line:

Code: Select all

C:\Users\mikek\Downloads\goreviewpartner-master>python leela_zero_analysis.py 2018-04-11d.sgf
GRP path: C:\Users\mikek\Downloads\goreviewpartner-master
Config file: C:\Users\mikek\Downloads\goreviewpartner-master\config.ini
Checking availability of config file
Reading language setting from config file
No language setting in the config file
System language detection:
System language: en (en_GB)
There is a translation available for lang=en
Saving the lang parameter in config.ini
Could not import the WX GUI library, please double check it is installed:
No module named wx
=> No problem, falling back to tkFileDialog
the sgf has no declared encoding, we will enforce UTF-8 encoding
Variation: 1
Moves for this variation: 294
Range: all
Color: both
Komi: 3.75
Profil: slow
Adding new popup
Totally 1 popups
File to analyse: 2018-04-11d.sgf
Could not open the SGF file 2
=> 2 No such file or directory
converting GRPException error message from unicode to str
Leaving follow_anlysis()
ERROR: Analysis aborted:

Could not open the RSGF file: 2
No such file or directory
Adding new popup
Totally 2 popups
Batch analysis failed
RunAnalysis instance has no attribute 'completed'

The stats about my sgf file give me hope that the script is basically finding the file and starting to work, but then the sgf path seems to be cut down to one character long and GRP fails to find it the second time?
Could you offer any advice?

[pnprog]

The stats about my sgf file give me hope that the script is basically finding the file and starting to work, but then the sgf path seems to be cut down to one character long and GRP fails to find it the second time?
Could you offer any advice?

My bad, 2 days ago, I made a modification in order to be able to resume an interrupted analysis (or perform a new analysis pass on a subset of moves), it's working well with the GUI, but did not try it with the command line, I guess that's the reason for the issue. I will fix that today.

[pnprog]

I will fix that today.

I just fixed it, please have a try.

For now, the feature to stop/resume the analysis is not available in batch mode.

[MikeKyle]

I just fixed it, please have a try.

This is working wonderfully, and I'm having fun with it!

Also really like the new review gui. Thank you for all your hard work.