Announcing GoReviewPartner - v0.15 with Pachi and PhoenixGo

Tell the community about tournaments, new go sites, software updates, etc.
User avatar
psygo
Dies in gote
Posts: 67
Joined: Fri Dec 11, 2015 8:20 am
Rank: KGS 2 Dan
GD Posts: 0
KGS: psygo
Tygem: psygo
OGS: psygo
Universal go server handle: psygo
Location: São Paulo, Brazil
Has thanked: 7 times
Been thanked: 7 times
Contact:

Re: Announcing GoReviewPartner - v0.12

Post by psygo »

First of all, congrats on creating such a powerful tool, all the more by doing it basically alone. That's genius to me.

Secondly, can anybody help me make it work? I don't understand much about python so I don't know what's going wrong. I have installed python (twice), but everytime I try to run any of the files a black window pops up and out in a second and nothing happens. Does anybody know what's going on? I even tried to run the files with PyCharm, but it says there are mistakes in the code and it just doesn't run the code.

I am probably doing something very basic wrongly, but I wish this was more user friendly, I would even be willing to pay for it (even more than I'm already willing to...).

Anyway, congrats on the software! :)
User avatar
pnprog
Lives with ko
Posts: 286
Joined: Thu Oct 20, 2016 7:21 am
Rank: OGS 7 kyu
GD Posts: 0
Has thanked: 94 times
Been thanked: 153 times

Re: Announcing GoReviewPartner - v0.12

Post by pnprog »

Hi!
psygo wrote:Secondly, can anybody help me make it work? I don't understand much about python so I don't know what's going wrong. I have installed python (twice), but everytime I try to run any of the files a black window pops up and out in a second and nothing happens. Does anybody know what's going on? I even tried to run the files with PyCharm, but it says there are mistakes in the code and it just doesn't run the code.
If you run Windows, the recommended way is to download a package with your favourite bot pre-configured there: http://yuntingdian.com/goreviewpartner/ You can find more explanations there.

If you run MacOs or Linux, or just want to ruYou can find more explanations there.n python, make sure to install python2, not python3 (sorry about that). On MacOs/Linux, you have to be sure to install tkinter as well. You can find more explanations there. The python file to run is main.py

By the way, I released a new (minor) update, v0.13, yesterday that adds a basic export to CSV file (among other things).
I am the author of GoReviewPartner, a small software aimed at assisting reviewing a game of Go. Give it a try!
User avatar
psygo
Dies in gote
Posts: 67
Joined: Fri Dec 11, 2015 8:20 am
Rank: KGS 2 Dan
GD Posts: 0
KGS: psygo
Tygem: psygo
OGS: psygo
Universal go server handle: psygo
Location: São Paulo, Brazil
Has thanked: 7 times
Been thanked: 7 times
Contact:

Re: Announcing GoReviewPartner - v0.12

Post by psygo »

Thank you for the help, I was trying to do the things you described, but kinda wrongly.

The first issue was more obvious, the Python version, I had a 3.X one, after installing the 2.7.13 one, everything worked fine. The second issue (which was actually prior to that) was that I would hit a 404 page not found after clicking on the bundled links you made available on your site, but that stopped happening a little bit later on.

Anyway, everything is working fine for now, and thanks again. There is just one odd detail that has been puzzling to me, is the Leela Zero ELF bundle working 100% ok? I've tried it here and the winning percentages barely change throughout the analysis. I've even tried to manually change the weights (is it recommended? it doesn't seem to work properly with the other versions either) to a more updated version, but with no success.
dbk
Beginner
Posts: 3
Joined: Sun Jul 15, 2018 9:13 am
Rank: BGA 7 Kyu
GD Posts: 0
Has thanked: 1 time

Re: GoReviewPartner - "leela_zero_goreviewpartner.ipynb"

Post by dbk »

leela_zero_goreviewpartner.ipynb is a notebook to run goreviewpartner in Google's colaboratory and so take advantage of the free GPU power generously provided by Google.

I think it must have worked once but doesn't anymore; there are at least two errors
  • the first is simple. The code

    Code: Select all

    #!sed -i -e '78,88d' $config
    is intended to truncate config.ini after [LeelaZero] and new parameters will later be added.

    It works if the code is replaced by

    Code: Select all

    !sed  -n -e '1,/^\[LeelaZero\]$/p' {config} > {config}.truncated
    !cp {config}.truncated {config}
  • I don't understand the second one; it reports an attempt to write to standard error,

    Code: Select all

    Starting LeelaZero...
    Leela Zero working directory: /content/leela-zero/src/
    Checking Leela Zero stderr to check for OpenCL SGEMM tuner running
    leaving consume_stderr thread
    Could not find out, abandoning
    LeelaZero started
    LeelaZero identification through GTP...
    Error while writting to stdin
Is the author here, or can an expert on GoReviewPartner suggest what is causing the second error? Eve better if the notebook were to be adopted by the project!
User avatar
pnprog
Lives with ko
Posts: 286
Joined: Thu Oct 20, 2016 7:21 am
Rank: OGS 7 kyu
GD Posts: 0
Has thanked: 94 times
Been thanked: 153 times

Re: Announcing GoReviewPartner - v0.12

Post by pnprog »

Hi!

I don't know about Colab or that project, but the error indicated by GRP ( Error while writting to stdin ) indicates an error while writing to LeelaZero's standard Input, not GRP's standard input.

The first thing GRP does after launching LeelaZero is to send the GTP commands name and version to ensure the correct program is running in GTP mode.

Failure to write to LeelaZero's stdin most probably means that LeelaZero crashed/terminated immediately after startup. You should check the command used for startup, and try to run it outside of GRP.

I never tried Colab, but I will see if I can have a try. From what I can understand, it should work for the newest or and older version of GRP.
I am the author of GoReviewPartner, a small software aimed at assisting reviewing a game of Go. Give it a try!
dbk
Beginner
Posts: 3
Joined: Sun Jul 15, 2018 9:13 am
Rank: BGA 7 Kyu
GD Posts: 0
Has thanked: 1 time

Re: Announcing GoReviewPartner - v0.12

Post by dbk »

Thanks. I've got it to start by reverting GoReviewPartner

Code: Select all

git checkout 928cd
but I don't yet know whether it will complete successfully. Later reversions may also work, I haven't tried them yet.
User avatar
pnprog
Lives with ko
Posts: 286
Joined: Thu Oct 20, 2016 7:21 am
Rank: OGS 7 kyu
GD Posts: 0
Has thanked: 94 times
Been thanked: 153 times

Re: Announcing GoReviewPartner - v0.12

Post by pnprog »

dbk wrote:Thanks. I've got it to start by reverting GoReviewPartner

Code: Select all

git checkout 928cd
but I don't yet know whether it will complete successfully. Later reversions may also work, I haven't tried them yet.
It's good to know this is working.
I had a quick look at the google colab FAQ, they say users are not supposed to use it for intensive CPU/GPU tasks (they mention cryptocurrency mining as an example). So they might be upset if user use it for game analysis.

Otherwise, I would be interested to make sure GRP runs fine on Colab. I see a cool use case where you enter the move from your smartphone, and the analysis is done on their servers.
I am the author of GoReviewPartner, a small software aimed at assisting reviewing a game of Go. Give it a try!
User avatar
pnprog
Lives with ko
Posts: 286
Joined: Thu Oct 20, 2016 7:21 am
Rank: OGS 7 kyu
GD Posts: 0
Has thanked: 94 times
Been thanked: 153 times

Re: Announcing GoReviewPartner - v0.12

Post by pnprog »

And here is a quick update regarding latest progresses:

I started implementing the "tabbed goban layout". So far so good. Here are some screenshots of the (work in progress) implementation:

Here is the main view. Both right and left panels always have an "Actual game" tab and an "Analysis" tab.

An "actual game" tab shows what next move was played, and can be used to play quickly try out variation (no bot available there). The variations played on this tab have move numbered.
An "analysis" tab shows the variations provided by the bot. The "filter" button is not implemented yet, but will offer way to restrict the variations displayed based on quantity/player/winrate intervals The "display" button can be used to quickly switch between "colouring" modes and "labelling" modes, as show on the picture below:
0.png
0.png (152.84 KiB) Viewed 18606 times
Those special tabs are synchronized and show information on the currently displayed moves. So it's possible to display the same type of board on both left and right, but it won't help that much because they will display the same information. However, it's possible to use different display setting, so for instance, one can display on the right the "Analysis tab" with "best variation in blue" and labelling using "letters", and on the left, the "analysis tab" but using "winning (>50%) variations in blue", and labelling using winrate% as on the picture bellow:
1.png
1.png (71.87 KiB) Viewed 18606 times
Then, pushing the "+" tab create a new tab, and make it available to play with the bot on this goban. The tabs are labelled using the move number where the variation starts, and are not synchronized with the "Actual game" and "Analysis" tabs. It is possible to open as much tabs as possible, so it can be used to "bookmark" a position during the review, to came back at it later:
2.png
2.png (70.45 KiB) Viewed 18606 times
What I still need to do:
  • The same way the "Actual game" and "Analysis" tabs are duplicated on left and right sides, I would like to duplicate the new tabs on both side. Currently, they are only available on the side they were created. This way, one can more easily compare the results of two variations by bringing them side to side
  • Implement the tabbed goban feature in the live analysis mode as well
  • Load a bot only on demand (Gogui uses the word "Attach"), so that opening more tab does not consume unnecessary memory
  • Add a way to close those new tabs
  • Add the heat map feature for the bots who support it
I am the author of GoReviewPartner, a small software aimed at assisting reviewing a game of Go. Give it a try!
User avatar
pnprog
Lives with ko
Posts: 286
Joined: Thu Oct 20, 2016 7:21 am
Rank: OGS 7 kyu
GD Posts: 0
Has thanked: 94 times
Been thanked: 153 times

Re: Announcing GoReviewPartner - v0.12

Post by pnprog »

Oups, almost forgot about this one:
psygo wrote:The first issue was more obvious, the Python version, I had a 3.X one, after installing the 2.7.13 one, everything worked fine. The second issue (which was actually prior to that) was that I would hit a 404 page not found after clicking on the bundled links you made available on your site, but that stopped happening a little bit later on.
This is probably because I had updated the download links, but your browser had cached the wab page. In such case, refreshing the page, using F5 should solve the issue.
psygo wrote:Anyway, everything is working fine for now, and thanks again. There is just one odd detail that has been puzzling to me, is the Leela Zero ELF bundle working 100% ok? I've tried it here and the winning percentages barely change throughout the analysis. I've even tried to manually change the weights (is it recommended? it doesn't seem to work properly with the other versions either) to a more updated version, but with no success.
I haven't had time to try ELF on my own games in fact. In fact, I spent almost all my "game of go time" programming...
Maybe have a try with Lizzie to see if the behaviour is the same?
I am the author of GoReviewPartner, a small software aimed at assisting reviewing a game of Go. Give it a try!
User avatar
pnprog
Lives with ko
Posts: 286
Joined: Thu Oct 20, 2016 7:21 am
Rank: OGS 7 kyu
GD Posts: 0
Has thanked: 94 times
Been thanked: 153 times

Re: Announcing GoReviewPartner - v0.14

Post by pnprog »

Hi everybody!

Here comes version 0.14, where the "tabbed" gobans feature was implemented. I am quite satisfied with the result, the interface is much more reactive than in in previous version, although resizing the three panel horizontal is still not that fast.

Opening new tabs allows to play with bots, but bots are not loaded in memory until they are selected.
GRP keep in memory the last bot used for each use case (analysis, live or interactive) and put it as default choice or first choice. So as a result, I remove all those dirty "Bot availability" settings that are not useful anymore.
Also, the logical next feature will be to add the possibility to add and name as much profiles has one needs, because only two profiles per bot (slow and fast) is not enough.
That would be cool to be able to cover each use case, for instance, for Leela Zero:
  • Leela Zero (30s/move)
  • Leela Zero (30s/move 2 GPU)
  • Leela Zero (CPU only)
  • Leela Zero (5s/move)
  • Leela Zero (ELF weights)
  • Leela Zero (9x9) <- yes there exist a 9x9 version
  • Leela Zero (network XXX) <- could need a specific weight version as well
  • Leela Zero (network YYY)
Apart from that tabbed gobans features, I also improved the support for maps:
  • GnuGo supports territories map and influence map
  • Leela supports influence map and heat map (only in 19x19)
  • Leela Zero supports the heat map
You will find the download links at the usual place: http://yuntingdian.com/goreviewpartner/
The (updated) documentation there includes plenty of screen-shots in you are interested.

So the features I have in mind for the next versions:
  • Possibility to add more profiles as described above
  • Possibility to add generic GTP bots as sparring partner in live game analysis (I need the above feature to be done for that one)
  • Replace export to CSV by Excel files with some colorfull formatting
But basically, I am pretty happy with the current result, it covers 99% of my needs already :)
That means we are getting really close to version 1.0, I want to ship that one with an installer, and file association, to be able to directly open RSGF files into GRP.
I am the author of GoReviewPartner, a small software aimed at assisting reviewing a game of Go. Give it a try!
Calvin Clark
Lives in gote
Posts: 426
Joined: Thu Aug 13, 2015 8:43 am
GD Posts: 0
Has thanked: 186 times
Been thanked: 191 times

Re: Announcing GoReviewPartner - v0.14

Post by Calvin Clark »

pnprog wrote:Here comes version 0.14, where the "tabbed" gobans feature was implemented.
What are the keyboard shortcuts for navigation now? It used to be that I could use the arrow keys to move through the game without using the mouse to click the "<<" and ">>" icons, but now those change the tabs.
User avatar
pnprog
Lives with ko
Posts: 286
Joined: Thu Oct 20, 2016 7:21 am
Rank: OGS 7 kyu
GD Posts: 0
Has thanked: 94 times
Been thanked: 153 times

Re: Announcing GoReviewPartner - v0.14

Post by pnprog »

Hi!
Calvin Clark wrote:What are the keyboard shortcuts for navigation now? It used to be that I could use the arrow keys to move through the game without using the mouse to click the "<<" and ">>" icons, but now those change the tabs.
Well, it's a bug I failed to notice :sad:
And a bug annoying enough that I decided to release a v0.14.1 to fix it (make sure to refresh the page). Sorry about the annoyance, and thanks for reporting the issue :)
I am the author of GoReviewPartner, a small software aimed at assisting reviewing a game of Go. Give it a try!
User avatar
pnprog
Lives with ko
Posts: 286
Joined: Thu Oct 20, 2016 7:21 am
Rank: OGS 7 kyu
GD Posts: 0
Has thanked: 94 times
Been thanked: 153 times

Re: Announcing GoReviewPartner - v0.14

Post by pnprog »

Hi everyone!

It has been a while since I last posted a message there, a bit more than 2 months. In fact, I was quite busy during that time, I (finally) got a job and moved to a new place (JiangSu/SuZhou). It took me some time to have everything settled, but now I am back to Go and programming.

I will probably not have as much time as in the past for Go and GRP, but I won't give up on those two hobbies of mine, I should still be able to put a couple of hours of work per week into GRP :D

And considering that I now have stable incomes, I am planning to purchase a computer (gaming computer with decent GPU) toward the end of the year, so that I can, too, enjoy all those juicy bots and new networks the way they deserve :lol:

I resumed GRP programming yesterday (thanks to Chine golden week!), and just now I added support for Pachi. I had been playing with it recently, and it presents a couples of advantages compared to the more cutting edges bots (LeelaZero, AQ, ELF...):
  • Works well on old computers
  • Plays equally well whatever the handicap, goban size or komi
  • Fills adequately the gap between GnuGo (too weak for me) and Leela (too strong for me) in term of strength
So it is becoming my goto Bot for training. The support is still pretty basic (no maps available yet) and I still needs to spend times on it before GRP is ready for next release.

I the mean time, I added the possibility to set as much different profiles for a bot as one may need:
profile_setting.png
profile_setting.png (21.24 KiB) Viewed 20080 times
I am the author of GoReviewPartner, a small software aimed at assisting reviewing a game of Go. Give it a try!
User avatar
MikeKyle
Lives with ko
Posts: 205
Joined: Wed Jul 26, 2017 2:27 am
Rank: EGF 2k
GD Posts: 0
KGS: MKyle
Has thanked: 49 times
Been thanked: 36 times

Re: Announcing GoReviewPartner - v0.14

Post by MikeKyle »

I just downloaded the latest GRP, set up some profiles (nice touch!) and had a try.

I can run everything fine with the GUI but I'm getting an error trying to run it from the command line.

I get this error in a pop up box:
Analysis aborted:
Error while initializing the GTP bot:
string indices must be integers
And the command line looks like this:
>python C:\Users\mikek\Documents\GRP_cmd\leela_zero_analysis.py --profil=slow C:\Users\mikek\Documents\XXX_XX\001\01\2018-04-02f.sgf
GRP path: C:\Users\mikek\Documents\GRP_cmd
Config file: C:\Users\mikek\Documents\GRP_cmd\config.ini
Checking availability of config file
Reading language setting from config file
lang=en
Could not import the WX GUI library, please double check it is installed:
Avoiding wx
=> No problem, falling back to tkFileDialog
the sgf has no declared encoding, we will enforce UTF-8 encoding
Variation: 1
Moves for this variation: 175
Range: all
Color: both
Komi: 6.5
Profil: slow
(Could not load the application icon)
Adding new popup
Totally 1 popups
File to analyse: C:\Users\mikek\Documents\XXX_XX\001\01\2018-04-02f.sgf
Output file: C:\Users\mikek\Documents\XXX_XX\001\01\2018-04-02f.rsgf
the sgf has no declared encoding, we will enforce UTF-8 encoding
keeping only variation 0
size of the tree: 19
Setting new komi
Leaving follow_anlysis()
ERROR: Analysis aborted:

Error while initializing the GTP bot:
string indices must be integers
Adding new popup
Totally 2 popups
Batch analysis failed
RunAnalysis instance has no attribute 'completed'
Can you identify anything I might be doing wrong?
User avatar
pnprog
Lives with ko
Posts: 286
Joined: Thu Oct 20, 2016 7:21 am
Rank: OGS 7 kyu
GD Posts: 0
Has thanked: 94 times
Been thanked: 153 times

Re: Announcing GoReviewPartner - v0.14

Post by pnprog »

Hi!
MikeKyle wrote:Can you identify anything I might be doing wrong?
You have done nothing wrong, it is just that I broke everything while implementing support for multi profiles. This is still in development, but of course everything will be fixed or the next release. Next release might be this week end or next week I hope.

My todo list at the moment:
  • Finalize support for Pachi (still some bugs in live analysis, when undoing moves), and add territory map
  • Make sure that modified version of LeelaZero (that works with different komi of handicap stones) works well with GRP
  • Check all previously existing features still function as usual, including the command line options
I am the author of GoReviewPartner, a small software aimed at assisting reviewing a game of Go. Give it a try!
Post Reply