Page 2 of 5
Re: Diagrams Should Work Now
Posted: Wed Apr 21, 2010 10:30 am
by Kirby
unkx80 wrote:Diagrams are now working. Wooooo!
However, diagram captions currently overlap the diagram itself. Please see:
viewtopic.php?f=15&t=56
Oops. Looks like there's a bug in the diagram word wrapping I worked on last night... Sorry about that. I'll try to have it fixed by the end of day today.
Re: Diagrams Should Work Now
Posted: Wed Apr 21, 2010 10:45 pm
by unkx80
Kirby wrote:unkx80 wrote:Diagrams are now working. Wooooo!
However, diagram captions currently overlap the diagram itself. Please see:
viewtopic.php?f=15&t=56
Oops. Looks like there's a bug in the diagram word wrapping I worked on last night... Sorry about that. I'll try to have it fixed by the end of day today.
I see that you have fixed it. Thanks!
Re: Diagrams Should Work Now
Posted: Wed Apr 21, 2010 10:53 pm
by Kirby
Hey unkx80,
I updated the captions. You should be able to have long text, and it should wrap now... Unless you find another bug
Re: Diagrams Should Work Now
Posted: Thu Apr 22, 2010 1:25 am
by apetresc
Testing to make sure the latest update to 3.0.7 hasn't broken anything.
$$Bc
$$ ---------------------------------------
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . X O O . . . . . . . . . . . . . . . |
$$ | . X X O O . . X . , . . . . . , X . . |
$$ | . X O X . . . . . . . . . . . . . . . |
$$ | . . O X . . . . . . . . . . . . . . . |
$$ | . . O B . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . , . . . . . , . . . . . , . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . O . . . . . . . . . . . . . . . |
$$ | . . . . . X . . . . . . . . . . . . . |
$$ | . . X . X . . . . . . . . . . . . . . |
$$ | . . . , . O . . . , . . . . . O . . . |
$$ | . . . O . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ ---------------------------------------
- Click Here To Show Diagram Code
[go]$$Bc
$$ ---------------------------------------
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . X O O . . . . . . . . . . . . . . . |
$$ | . X X O O . . X . , . . . . . , X . . |
$$ | . X O X . . . . . . . . . . . . . . . |
$$ | . . O X . . . . . . . . . . . . . . . |
$$ | . . O B . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . , . . . . . , . . . . . , . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . O . . . . . . . . . . . . . . . |
$$ | . . . . . X . . . . . . . . . . . . . |
$$ | . . X . X . . . . . . . . . . . . . . |
$$ | . . . , . O . . . , . . . . . O . . . |
$$ | . . . O . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ ---------------------------------------[/go]
http://files.gokgs.com/games/2008/7/12/tartrate-flyingfox.sgf
Edit: Cool, looks like everything made it through alright
Re: Diagrams Should Work Now
Posted: Thu Apr 22, 2010 2:16 am
by HermanHiddema
Great work on the diagrams, I'm happy that we can use the new features that have been implemented for a long time already on Sensei's Library, like setting a starting number for the moves.
@Joaz: Although you cannot nest indent tags, you can nest list tags:
$$Bm13 No list tags
$$ +-------
$$ | . . . . .
$$ | . . . . .
$$ | . 2 . 1 .
$$ | . . . . .
- Click Here To Show Diagram Code
[go]$$Bm13 No list tags
$$ +-------
$$ | . . . . .
$$ | . . . . .
$$ | . 2 . 1 .
$$ | . . . . .[/go]
Re: Diagrams Should Work Now
Posted: Thu Apr 22, 2010 9:33 am
by Kirby
Joaz Banbeck wrote:Jordus wrote:...to do this just wrap the go tags with indent tags...
Thanks. Ideally, I'd like nested indents.
Heck, while I'm wishing, I'd like arrows ( multi-colored ) and clouds or regions ( sort of likethe purple 'define region' function of eidogo, but not limited to being rectangular - also multi-colored )
For the latter part of your request, do you mean that you'd like the ability to draw a convex shape around an area on the board (a hexagon, for example)?
Re: Diagrams Should Work Now
Posted: Thu Apr 22, 2010 9:59 am
by fwiffo
You can do anything that can be done with Sensei's diagrams, so lines, arrows and certain kinds of shading are possible using diagram search thingies.
$$B
$$ ----------------
$$ | . . . V B . . . .
$$ | . . B ? ? V B . .
$$ | . V ? ? ? ? ? V .
$$ | . B ? ? ? ? ? ? B
$$ | V ? ? ? ? ? ? ? V
$$ | B ? ? ? ? ? ? B .
$$ | . V ? ? ? ? ? V .
$$ | . . B V ? ? B . .
$$ | . . . . B V . . .
$$ {LN D18 H16}
$$ {LN H16 F12}
$$ {LN F12 B14}
$$ {LN B14 D18}
$$ [B|FooBar]
- Click Here To Show Diagram Code
[go]$$B
$$ ----------------
$$ | . . . V B . . . .
$$ | . . B ? ? V B . .
$$ | . V ? ? ? ? ? V .
$$ | . B ? ? ? ? ? ? B
$$ | V ? ? ? ? ? ? ? V
$$ | B ? ? ? ? ? ? B .
$$ | . V ? ? ? ? ? V .
$$ | . . B V ? ? B . .
$$ | . . . . B V . . .
$$ {LN D18 H16}
$$ {LN H16 F12}
$$ {LN F12 B14}
$$ {LN B14 D18}
$$ [B|FooBar][/go]
Those are all things that are available in the SGF standard too; differen't colored lines and arrows aren't able to be specified in SGF, so that might be harder. I may dig in to the sltxt2png code to see what can be done. I always wished that the diagrams were prettily anti-aliased. But now I'm making too many projects for myself...
Re: Diagrams Should Work Now
Posted: Thu Apr 22, 2010 10:05 am
by Phelan
fwiffo wrote:You can do anything that can be done with Sensei's diagrams, so lines, arrows and certain kinds of shading are possible using diagram search thingies.
$$B
$$ ----------------
$$ | . . . V B . . . .
$$ | . . B ? ? V B . .
$$ | . V ? ? ? ? ? V .
$$ | . B ? ? ? ? ? ? B
$$ | V ? ? ? ? ? ? ? V
$$ | B ? ? ? ? ? ? B .
$$ | . V ? ? ? ? ? V .
$$ | . . B V ? ? B . .
$$ | . . . . B V . . .
$$ {LN D18 H16}
$$ {LN H16 F12}
$$ {LN F12 B14}
$$ {LN B14 D18}
$$ [B|FooBar]
- Click Here To Show Diagram Code
[go]$$B
$$ ----------------
$$ | . . . V B . . . .
$$ | . . B ? ? V B . .
$$ | . V ? ? ? ? ? V .
$$ | . B ? ? ? ? ? ? B
$$ | V ? ? ? ? ? ? ? V
$$ | B ? ? ? ? ? ? B .
$$ | . V ? ? ? ? ? V .
$$ | . . B V ? ? B . .
$$ | . . . . B V . . .
$$ {LN D18 H16}
$$ {LN H16 F12}
$$ {LN F12 B14}
$$ {LN B14 D18}
$$ [B|FooBar][/go]
Awesome image!
Re: Diagrams Should Work Now
Posted: Thu Apr 22, 2010 10:09 am
by Kirby
fwiffo wrote:You can do anything that can be done with Sensei's diagrams, so lines, arrows and certain kinds of shading are possible using diagram search thingies.
$$B
$$ ----------------
$$ | . . . V B . . . .
$$ | . . B ? ? V B . .
$$ | . V ? ? ? ? ? V .
$$ | . B ? ? ? ? ? ? B
$$ | V ? ? ? ? ? ? ? V
$$ | B ? ? ? ? ? ? B .
$$ | . V ? ? ? ? ? V .
$$ | . . B V ? ? B . .
$$ | . . . . B V . . .
$$ {LN D18 H16}
$$ {LN H16 F12}
$$ {LN F12 B14}
$$ {LN B14 D18}
$$ [B|FooBar]
- Click Here To Show Diagram Code
[go]$$B
$$ ----------------
$$ | . . . V B . . . .
$$ | . . B ? ? V B . .
$$ | . V ? ? ? ? ? V .
$$ | . B ? ? ? ? ? ? B
$$ | V ? ? ? ? ? ? ? V
$$ | B ? ? ? ? ? ? B .
$$ | . V ? ? ? ? ? V .
$$ | . . B V ? ? B . .
$$ | . . . . B V . . .
$$ {LN D18 H16}
$$ {LN H16 F12}
$$ {LN F12 B14}
$$ {LN B14 D18}
$$ [B|FooBar][/go]
Those are all things that are available in the SGF standard too; differen't colored lines and arrows aren't able to be specified in SGF, so that might be harder. I may dig in to the sltxt2png code to see what can be done. I always wished that the diagrams were prettily anti-aliased. But now I'm making too many projects for myself...
Yes, leave some for me to work on
Re: Diagrams Should Work Now
Posted: Thu Apr 22, 2010 11:49 am
by wms
Help! MY DIAGRAM ASPLODE!
See
viewtopic.php?f=37&t=161&p=984#p984When I edit, I see the "go" tags with the $$ stuff in between. But when I save it, it sprays all this crap all over.
What do I do to fix it?
Re: Diagrams Should Work Now
Posted: Thu Apr 22, 2010 12:27 pm
by Kirby
Thanks, wms. You found another bug. For now, try using "Move 55" instead of "Move #55". I'll fix this when I come home from work tonight.
Re: Diagrams Should Work Now
Posted: Thu Apr 22, 2010 12:56 pm
by fwiffo
One thing that is going to cause trouble for a lot of characters is embedding the go code inside the Javascript tag. I worked around that for the EidoGo thing by putting the {TEXT} portion inside a separate tag and having the javascript pull it out using foo.innerHTML or some such. Of course, you'll still have to escape &, ?, #, etc. for the call to the server and undo the conversion of newlines to <br /> and other mangling phpbb does. But you won't have to worry about characters that potentially break Javascript strings (e.g. \, ", etc. which have the potential for malicious javascript injection too).
Re: Diagrams Should Work Now
Posted: Thu Apr 22, 2010 3:23 pm
by Jordus
testing
should the size of the stone smilies be smaller?
Re: Diagrams Should Work Now
Posted: Thu Apr 22, 2010 3:28 pm
by Phelan
I like the size,
ut you should avoid having words with
on them on the forum.
Bee,
utterfly,
aby.
You should
e careful about what to use for smilie substitution.
Re: Diagrams Should Work Now
Posted: Thu Apr 22, 2010 3:29 pm
by Jordus
my bad
right now it is ":black:" for the smilie. should I switch it to something else?
and for the rest i i think
, b2, b3 etc is good no?
for white it will mirror black with b replaced with w