Diagrams Should Work Now

Is something wrong? Do you have any suggestions? Let us know.
User avatar
fwiffo
Gosei
Posts: 1435
Joined: Tue Apr 20, 2010 6:22 am
Rank: Out of practice
GD Posts: 1104
KGS: fwiffo
Location: California
Has thanked: 49 times
Been thanked: 168 times

Re: Diagrams Should Work Now

Post by fwiffo »

I think they should all have colons for consistency, e.g. :black:, :b1:, :b2:, :w1:, :w2:, etc. That's the standard for "exotic" smileys, like :ugeek: == Image, etc.
User avatar
schultz
Lives in gote
Posts: 505
Joined: Tue Apr 20, 2010 5:31 pm
GD Posts: 0
Location: Montana
Has thanked: 80 times
Been thanked: 62 times

Re: Diagrams Should Work Now

Post by schultz »

fwiffo wrote:I think they should all have colons for consistency, e.g. :black:, :b1:, :b2:, :w1:, :w2:, etc. That's the standard for "exotic" smileys, like :ugeek: == Image, etc.

Agreed. Better to keep things consistent. And good to see it was already fixed so it does take the colon and the word. There were a few pretty funny posts because of the non-unique matching. ;)
KGS: schultz [?].
Kirby
Honinbo
Posts: 9553
Joined: Wed Feb 24, 2010 6:04 pm
GD Posts: 0
KGS: Kirby
Tygem: 커비라고해
Has thanked: 1583 times
Been thanked: 1707 times

Re: Diagrams Should Work Now

Post by Kirby »

Added SGF hyperlinks to diagrams, so that you can download them.
be immersed
User avatar
sumiyaka
Dies with sente
Posts: 72
Joined: Wed Apr 21, 2010 5:00 pm
Rank: 4K
GD Posts: 1393
Been thanked: 2 times

Re: Diagrams Should Work Now

Post by sumiyaka »

I "think" I had an issue with white space in front of a diagram line....

For example this doesn't work ... the diagram was cut n' pasted from a working diagram's "show code" link. The space added to the beginning breaks it....

Click Here To Show Diagram Code
[go]$$c
$$ ---------------------------------------
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . X . |
$$ | . . . O . . O O . X . . X X . O O X . |
$$ | . . . , . . . X . , . . O . O . X . . |
$$ | . . O . . . . . . X X . O . . . . . . |
$$ | . . . . . . . . . X O . . . O X . . . |
$$ | . . . . . . . . . O O . O . X X . . . |
$$ | . . . . . . . . . . . . . . . . . X . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . X , . . . . . , . . . . . , . O . |
$$ | . . . . . . . . . . . . . . . X X O . |
$$ | . . . . . . . . . . . . . . . . O . . |
$$ | . . . . . . . . . . . . . . . O . . . |
$$ | . . . . . . . . . . . B O . . O X . . |
$$ | . . . . . . . . . . . . . . . . X . . |
$$ | . . X , . . . . . , . X . O . O . X . |
$$ | . . . . X . O . . O . X . . . O X . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ ---------------------------------------[/go]
User avatar
Jordus
Site Admin
Posts: 1125
Joined: Fri Dec 04, 2009 6:06 pm
Rank: KGS 9k
GD Posts: 0
Universal go server handle: Jordus
Location: Allegan, MI, USA
Has thanked: 16 times
Been thanked: 116 times
Contact:

Re: Diagrams Should Work Now

Post by Jordus »

i think I got it fixed.... and added the go tags in the copy code
I'm thinking...
User avatar
sumiyaka
Dies with sente
Posts: 72
Joined: Wed Apr 21, 2010 5:00 pm
Rank: 4K
GD Posts: 1393
Been thanked: 2 times

Re: Diagrams Should Work Now

Post by sumiyaka »

Jordus, when you pasted that in did it not put 4 spaces in front of every line?

EDIT: You are faster than my question....
User avatar
Jordus
Site Admin
Posts: 1125
Joined: Fri Dec 04, 2009 6:06 pm
Rank: KGS 9k
GD Posts: 0
Universal go server handle: Jordus
Location: Allegan, MI, USA
Has thanked: 16 times
Been thanked: 116 times
Contact:

Re: Diagrams Should Work Now

Post by Jordus »

when taking from an original diagram it did... not from your source...

however, when I added the go tags to the source code, the diagrams that did put spaces before for me didnt....

so hopefully that took care of it.
I'm thinking...
User avatar
sumiyaka
Dies with sente
Posts: 72
Joined: Wed Apr 21, 2010 5:00 pm
Rank: 4K
GD Posts: 1393
Been thanked: 2 times

Re: Diagrams Should Work Now

Post by sumiyaka »

Sounds good, it should be a good fix, at least for the time being.

At some point the diagrammer could be taught to ignore any whitespace prior to a '$', but for now, who cares, on with the Malkovich games! :D
Kirby
Honinbo
Posts: 9553
Joined: Wed Feb 24, 2010 6:04 pm
GD Posts: 0
KGS: Kirby
Tygem: 커비라고해
Has thanked: 1583 times
Been thanked: 1707 times

Re: Diagrams Should Work Now

Post by Kirby »

sumiyaka wrote:Sounds good, it should be a good fix, at least for the time being.

At some point the diagrammer could be taught to ignore any whitespace prior to a '$', but for now, who cares, on with the Malkovich games! :D


I'll try to get to this today or tomorrow.
be immersed
Kirby
Honinbo
Posts: 9553
Joined: Wed Feb 24, 2010 6:04 pm
GD Posts: 0
KGS: Kirby
Tygem: 커비라고해
Has thanked: 1583 times
Been thanked: 1707 times

Re: Diagrams Should Work Now

Post by Kirby »

test...

Click Here To Show Diagram Code
[go]$$Bc
$$ ---------------------------------------
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . X O O . . . . . . . . . . . . . . . |
$$ | . X X O O . . X . , . . . . . , X . . |
$$ | . X O X . . . . . . . . . . . . . . . |
$$ | . . O X . . . . . . . . . . . . . . . |
$$ | . . O B . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . , . . . . . , . . . . . , . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . O . . . . . . . . . . . . . . . |
$$ | . . . . . X . . . . . . . . . . . . . |
$$ | . . X . X . . . . . . . . . . . . . . |
$$ | . . . , . O . . . , . . . . . O . . . |
$$ | . . . O . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ ---------------------------------------[/go]


                              
Click Here To Show Diagram Code
[go]$$Bc
$$ ---------------------------------------
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . X O O . . . . . . . . . . . . . . . |
$$ | . X X O O . . X . , . . . . . , X . . |
$$ | . X O X . . . . . . . . . . . . . . . |
$$ | . . O X . . . . . . . . . . . . . . . |
$$ | . . O B . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . , . . . . . , . . . . . , . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . O . . . . . . . . . . . . . . . |
$$ | . . . . . X . . . . . . . . . . . . . |
$$ | . . X . X . . . . . . . . . . . . . . |
$$ | . . . , . O . . . , . . . . . O . . . |
$$ | . . . O . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ ---------------------------------------[/go]


[indent]
Click Here To Show Diagram Code
[go]$$Bc
$$ ---------------------------------------
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . X O O . . . . . . . . . . . . . . . |
$$ | . X X O O . . X . , . . . . . , X . . |
$$ | . X O X . . . . . . . . . . . . . . . |
$$ | . . O X . . . . . . . . . . . . . . . |
$$ | . . O B . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . , . . . . . , . . . . . , . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . O . . . . . . . . . . . . . . . |
$$ | . . . . . X . . . . . . . . . . . . . |
$$ | . . X . X . . . . . . . . . . . . . . |
$$ | . . . , . O . . . , . . . . . O . . . |
$$ | . . . O . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ ---------------------------------------[/go]
[/indent]
be immersed
Bill Spight
Honinbo
Posts: 10905
Joined: Wed Apr 21, 2010 1:24 pm
Has thanked: 3651 times
Been thanked: 3373 times

Proportional font

Post by Bill Spight »

I just ran into a problem with editing a diagram. The diagram code was in a proportional font, which makes it difficult to make an accurate edit. Now, I could copy it to a text editor on my computer before posting a comment with the edited diagram, but it would be nice to change the font online. :) Or maybe all diagram code could be converted to Courier automatically?
The Adkins Principle:
At some point, doesn't thinking have to go on?
— Winona Adkins

Visualize whirled peas.

Everything with love. Stay safe.
xed_over
Oza
Posts: 2264
Joined: Mon Apr 19, 2010 11:51 am
Has thanked: 1179 times
Been thanked: 553 times

Re: Proportional font

Post by xed_over »

Bill Spight wrote:I just ran into a problem with editing a diagram. The diagram code was in a proportional font, which makes it difficult to make an accurate edit. Now, I could copy it to a text editor on my computer before posting a comment with the edited diagram, but it would be nice to change the font online. :) Or maybe all diagram code could be converted to Courier automatically?

I thought they fixed it in this Monospaced Font thread. But maybe they forgot about post edits.
User avatar
fwiffo
Gosei
Posts: 1435
Joined: Tue Apr 20, 2010 6:22 am
Rank: Out of practice
GD Posts: 1104
KGS: fwiffo
Location: California
Has thanked: 49 times
Been thanked: 168 times

Re: Diagrams Should Work Now

Post by fwiffo »

Should already be fixed - what browser are you using?
User avatar
Solomon
Gosei
Posts: 1848
Joined: Tue Apr 20, 2010 9:21 pm
Rank: AGA 5d
GD Posts: 0
KGS: Capsule 4d
Tygem: 치킨까스 5d
Location: Bellevue, WA
Has thanked: 90 times
Been thanked: 835 times

Re: Diagrams Should Work Now

Post by Solomon »

On my end, the font doesn't come out correctly for Safari 4 and Chrome 5 (beta) on OS X. Comes out correctly for Firefox 3.5.9 on OS X, Firefox 3.6.3 on Win7, and Chrome 4.1 on Win7.
User avatar
fwiffo
Gosei
Posts: 1435
Joined: Tue Apr 20, 2010 6:22 am
Rank: Out of practice
GD Posts: 1104
KGS: fwiffo
Location: California
Has thanked: 49 times
Been thanked: 168 times

Re: Diagrams Should Work Now

Post by fwiffo »

Just so I'm clear - which is showing up wrong, the text in the "show diagram code" thing or the text in the <textarea> when you're editing a post?
Post Reply