Diagrams Should Work Now

Is something wrong? Do you have any suggestions? Let us know.
Post Reply
Kirby
Honinbo
Posts: 9553
Joined: Wed Feb 24, 2010 6:04 pm
GD Posts: 0
KGS: Kirby
Tygem: 커비라고해
Has thanked: 1583 times
Been thanked: 1707 times

Re: Diagrams Should Work Now

Post by Kirby »

unkx80 wrote:Diagrams are now working. Wooooo!

However, diagram captions currently overlap the diagram itself. Please see:
viewtopic.php?f=15&t=56


Oops. Looks like there's a bug in the diagram word wrapping I worked on last night... Sorry about that. I'll try to have it fixed by the end of day today.
be immersed
Top
unkx80
Lives with ko
Posts: 257
Joined: Tue Apr 20, 2010 12:21 am
Rank: Dan player
GD Posts: 0
Location: Singapore
Has thanked: 13 times
Been thanked: 30 times
Contact:
Contact unkx80

Re: Diagrams Should Work Now

Post by unkx80 »

Kirby wrote:
unkx80 wrote:Diagrams are now working. Wooooo!

However, diagram captions currently overlap the diagram itself. Please see:
viewtopic.php?f=15&t=56


Oops. Looks like there's a bug in the diagram word wrapping I worked on last night... Sorry about that. I'll try to have it fixed by the end of day today.


I see that you have fixed it. Thanks! :)
Top
Kirby
Honinbo
Posts: 9553
Joined: Wed Feb 24, 2010 6:04 pm
GD Posts: 0
KGS: Kirby
Tygem: 커비라고해
Has thanked: 1583 times
Been thanked: 1707 times

Re: Diagrams Should Work Now

Post by Kirby »

unkx80 wrote:Diagrams are now working. Wooooo!

However, diagram captions currently overlap the diagram itself. Please see:
http://www.lifein19x19.com/forum/viewto ... ?f=15&t=56


Hey unkx80,
I updated the captions. You should be able to have long text, and it should wrap now... Unless you find another bug ;)
be immersed
Top
User avatar
apetresc
Lives with ko
Posts: 256
Joined: Wed Apr 21, 2010 3:42 pm
Rank: AGA 1k
GD Posts: 1190
KGS: apetresc
IGS: apetresc
OGS: apetresc
Universal go server handle: apetresc
Location: Waterloo, Ontario (Canada)
Has thanked: 110 times
Been thanked: 146 times
Contact:
Contact apetresc

Re: Diagrams Should Work Now

Post by apetresc »

Testing to make sure the latest update to 3.0.7 hasn't broken anything.

Click Here To Show Diagram Code
[go]$$Bc
$$ ---------------------------------------
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . X O O . . . . . . . . . . . . . . . |
$$ | . X X O O . . X . , . . . . . , X . . |
$$ | . X O X . . . . . . . . . . . . . . . |
$$ | . . O X . . . . . . . . . . . . . . . |
$$ | . . O B . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . , . . . . . , . . . . . , . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . O . . . . . . . . . . . . . . . |
$$ | . . . . . X . . . . . . . . . . . . . |
$$ | . . X . X . . . . . . . . . . . . . . |
$$ | . . . , . O . . . , . . . . . O . . . |
$$ | . . . O . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ | . . . . . . . . . . . . . . . . . . . |
$$ ---------------------------------------[/go]




Edit: Cool, looks like everything made it through alright :)
The road to wisdom? Well, it's plain, and simple to express: Err, and err, and err again; but less, and less, and less!
Image Image Image Image
Top
User avatar
HermanHiddema
Gosei
Posts: 2011
Joined: Tue Apr 20, 2010 10:08 am
Rank: Dutch 4D
GD Posts: 645
Universal go server handle: herminator
Location: Groningen, NL
Has thanked: 202 times
Been thanked: 1086 times

Re: Diagrams Should Work Now

Post by HermanHiddema »

Great work on the diagrams, I'm happy that we can use the new features that have been implemented for a long time already on Sensei's Library, like setting a starting number for the moves.

@Joaz: Although you cannot nest indent tags, you can nest list tags:

Click Here To Show Diagram Code
[go]$$Bm13 No list tags
$$ +-------
$$ | . . . . .
$$ | . . . . .
$$ | . 2 . 1 .
$$ | . . . . .[/go]


    Click Here To Show Diagram Code
    [go]$$Bm13 1 list tag
    $$ +-------
    $$ | . . . . .
    $$ | . . . . .
    $$ | . 2 . 1 .
    $$ | . . . . .[/go]

      Click Here To Show Diagram Code
      [go]$$Bm13 2 list tags
      $$ +-------
      $$ | . . . . .
      $$ | . . . . .
      $$ | . 2 . 1 .
      $$ | . . . . .[/go]


      If you don't put * tags in front of lines, they dont have dots in front of them, so you can nest your comments on the same level as your diagram.

    • With a * tag they do have dots...


        Click Here To Show Diagram Code
        [go]$$Bm13 3 list tags
        $$ +-------
        $$ | . . . . .
        $$ | . . . . .
        $$ | . 2 . 1 .
        $$ | . . . . .[/go]
Top
Kirby
Honinbo
Posts: 9553
Joined: Wed Feb 24, 2010 6:04 pm
GD Posts: 0
KGS: Kirby
Tygem: 커비라고해
Has thanked: 1583 times
Been thanked: 1707 times

Re: Diagrams Should Work Now

Post by Kirby »

Joaz Banbeck wrote:
Jordus wrote:...to do this just wrap the go tags with indent tags...


Thanks. Ideally, I'd like nested indents.

Heck, while I'm wishing, I'd like arrows ( multi-colored ) and clouds or regions ( sort of likethe purple 'define region' function of eidogo, but not limited to being rectangular - also multi-colored )


For the latter part of your request, do you mean that you'd like the ability to draw a convex shape around an area on the board (a hexagon, for example)?
be immersed
Top
User avatar
fwiffo
Gosei
Posts: 1435
Joined: Tue Apr 20, 2010 6:22 am
Rank: Out of practice
GD Posts: 1104
KGS: fwiffo
Location: California
Has thanked: 49 times
Been thanked: 168 times

Re: Diagrams Should Work Now

Post by fwiffo »

You can do anything that can be done with Sensei's diagrams, so lines, arrows and certain kinds of shading are possible using diagram search thingies.

Click Here To Show Diagram Code
[go]$$B
$$ ----------------
$$ | . . . V B . . . .
$$ | . . B ? ? V B . .
$$ | . V ? ? ? ? ? V .
$$ | . B ? ? ? ? ? ? B
$$ | V ? ? ? ? ? ? ? V
$$ | B ? ? ? ? ? ? B .
$$ | . V ? ? ? ? ? V .
$$ | . . B V ? ? B . .
$$ | . . . . B V . . .
$$ {LN D18 H16}
$$ {LN H16 F12}
$$ {LN F12 B14}
$$ {LN B14 D18}
$$ [B|FooBar][/go]

Those are all things that are available in the SGF standard too; differen't colored lines and arrows aren't able to be specified in SGF, so that might be harder. I may dig in to the sltxt2png code to see what can be done. I always wished that the diagrams were prettily anti-aliased. But now I'm making too many projects for myself...
Top
User avatar
Phelan
Gosei
Posts: 1449
Joined: Tue Apr 20, 2010 3:15 pm
Rank: KGS 6k
GD Posts: 892
Has thanked: 1550 times
Been thanked: 140 times

Re: Diagrams Should Work Now

Post by Phelan »

fwiffo wrote:You can do anything that can be done with Sensei's diagrams, so lines, arrows and certain kinds of shading are possible using diagram search thingies.

Click Here To Show Diagram Code
[go]$$B
$$ ----------------
$$ | . . . V B . . . .
$$ | . . B ? ? V B . .
$$ | . V ? ? ? ? ? V .
$$ | . B ? ? ? ? ? ? B
$$ | V ? ? ? ? ? ? ? V
$$ | B ? ? ? ? ? ? B .
$$ | . V ? ? ? ? ? V .
$$ | . . B V ? ? B . .
$$ | . . . . B V . . .
$$ {LN D18 H16}
$$ {LN H16 F12}
$$ {LN F12 B14}
$$ {LN B14 D18}
$$ [B|FooBar][/go]

:o Awesome image!
a1h1 [1d]: You just need to curse the gods and defend.
Good Go = Shape.
Associação Portuguesa de Go
Top
Kirby
Honinbo
Posts: 9553
Joined: Wed Feb 24, 2010 6:04 pm
GD Posts: 0
KGS: Kirby
Tygem: 커비라고해
Has thanked: 1583 times
Been thanked: 1707 times

Re: Diagrams Should Work Now

Post by Kirby »

fwiffo wrote:You can do anything that can be done with Sensei's diagrams, so lines, arrows and certain kinds of shading are possible using diagram search thingies.

Click Here To Show Diagram Code
[go]$$B
$$ ----------------
$$ | . . . V B . . . .
$$ | . . B ? ? V B . .
$$ | . V ? ? ? ? ? V .
$$ | . B ? ? ? ? ? ? B
$$ | V ? ? ? ? ? ? ? V
$$ | B ? ? ? ? ? ? B .
$$ | . V ? ? ? ? ? V .
$$ | . . B V ? ? B . .
$$ | . . . . B V . . .
$$ {LN D18 H16}
$$ {LN H16 F12}
$$ {LN F12 B14}
$$ {LN B14 D18}
$$ [B|FooBar][/go]

Those are all things that are available in the SGF standard too; differen't colored lines and arrows aren't able to be specified in SGF, so that might be harder. I may dig in to the sltxt2png code to see what can be done. I always wished that the diagrams were prettily anti-aliased. But now I'm making too many projects for myself...


Yes, leave some for me to work on ;)
be immersed
Top
User avatar
wms
Lives in gote
Posts: 450
Joined: Tue Apr 20, 2010 4:23 pm
GD Posts: 0
KGS: wms
Location: Portland, OR USA
Has thanked: 257 times
Been thanked: 287 times
Contact:
Contact wms

Re: Diagrams Should Work Now

Post by wms »

Help! MY DIAGRAM ASPLODE!

See viewtopic.php?f=37&t=161&p=984#p984

When I edit, I see the "go" tags with the $$ stuff in between. But when I save it, it sprays all this crap all over.

What do I do to fix it?
Top
Kirby
Honinbo
Posts: 9553
Joined: Wed Feb 24, 2010 6:04 pm
GD Posts: 0
KGS: Kirby
Tygem: 커비라고해
Has thanked: 1583 times
Been thanked: 1707 times

Re: Diagrams Should Work Now

Post by Kirby »

wms wrote:Help! MY DIAGRAM ASPLODE!

See http://lifein19x19.com/forum/viewtopic. ... p=984#p984

When I edit, I see the "go" tags with the $$ stuff in between. But when I save it, it sprays all this crap all over.

What do I do to fix it?


Thanks, wms. You found another bug. For now, try using "Move 55" instead of "Move #55". I'll fix this when I come home from work tonight.
be immersed
Top
User avatar
fwiffo
Gosei
Posts: 1435
Joined: Tue Apr 20, 2010 6:22 am
Rank: Out of practice
GD Posts: 1104
KGS: fwiffo
Location: California
Has thanked: 49 times
Been thanked: 168 times

Re: Diagrams Should Work Now

Post by fwiffo »

One thing that is going to cause trouble for a lot of characters is embedding the go code inside the Javascript tag. I worked around that for the EidoGo thing by putting the {TEXT} portion inside a separate tag and having the javascript pull it out using foo.innerHTML or some such. Of course, you'll still have to escape &, ?, #, etc. for the call to the server and undo the conversion of newlines to <br /> and other mangling phpbb does. But you won't have to worry about characters that potentially break Javascript strings (e.g. \, ", etc. which have the potential for malicious javascript injection too).
Top
User avatar
Jordus
Site Admin
Posts: 1125
Joined: Fri Dec 04, 2009 6:06 pm
Rank: KGS 9k
GD Posts: 0
Universal go server handle: Jordus
Location: Allegan, MI, USA
Has thanked: 16 times
Been thanked: 116 times
Contact:
Contact Jordus

Re: Diagrams Should Work Now

Post by Jordus »

testing black

should the size of the stone smilies be smaller?
I'm thinking...
Top
User avatar
Phelan
Gosei
Posts: 1449
Joined: Tue Apr 20, 2010 3:15 pm
Rank: KGS 6k
GD Posts: 892
Has thanked: 1550 times
Been thanked: 140 times

Re: Diagrams Should Work Now

Post by Phelan »

I like the size, but you should avoid having words with b on them on the forum. :P
Bee, butterfly, baby.

You should be careful about what to use for smilie substitution.
a1h1 [1d]: You just need to curse the gods and defend.
Good Go = Shape.
Associação Portuguesa de Go
Top
User avatar
Jordus
Site Admin
Posts: 1125
Joined: Fri Dec 04, 2009 6:06 pm
Rank: KGS 9k
GD Posts: 0
Universal go server handle: Jordus
Location: Allegan, MI, USA
Has thanked: 16 times
Been thanked: 116 times
Contact:
Contact Jordus

Re: Diagrams Should Work Now

Post by Jordus »

my bad :P

right now it is ":black:" for the smilie. should I switch it to something else? :black:

and for the rest i i think b1, b2, b3 etc is good no?

for white it will mirror black with b replaced with w
I'm thinking...
Top
Post Reply

Return to “Forum/Site Suggestions and Bugs”